-
Notifications
You must be signed in to change notification settings - Fork 57
Add ols config collection #2582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/assign @xrajesh Can you review pls? |
| config.query_redactor # pylint: disable=W0104 | ||
|
|
||
| # store service configuration if enabled | ||
| if not config.ols_config.user_data_collection.config_disabled: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onmete We have the config file in /etc/ols/olsconfig.yaml right , we cant use that as is without this new file ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to copy data to utilize how the current data collector works to store the data in the expected way and location, to also avoid accidental deletion.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I believe e2e will be failing until we merge operator side openshift/lightspeed-operator#906 |
|
Looks good - it will be nice to add the developer config with the new fields here https://github.com/openshift/lightspeed-service/tree/main/ols/user_data_collection#how-to-test-locally |
|
@onmete: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
|
obsolete |
Description
This adds the olsconfig.yaml as a new datapoint.
Operator PR: openshift/lightspeed-operator#906
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing