Skip to content

Conversation

@onmete
Copy link
Contributor

@onmete onmete commented Aug 12, 2025

Description

This adds the olsconfig.yaml as a new datapoint.
Operator PR: openshift/lightspeed-operator#906

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@onmete
Copy link
Contributor Author

onmete commented Aug 13, 2025

/assign @xrajesh

Can you review pls?

config.query_redactor # pylint: disable=W0104

# store service configuration if enabled
if not config.ols_config.user_data_collection.config_disabled:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onmete We have the config file in /etc/ols/olsconfig.yaml right , we cant use that as is without this new file ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to copy data to utilize how the current data collector works to store the data in the expected way and location, to also avoid accidental deletion.

@openshift-ci
Copy link

openshift-ci bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from xrajesh. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@onmete
Copy link
Contributor Author

onmete commented Aug 14, 2025

I believe e2e will be failing until we merge operator side openshift/lightspeed-operator#906

@xrajesh
Copy link
Contributor

xrajesh commented Aug 19, 2025

Looks good - it will be nice to add the developer config with the new fields here https://github.com/openshift/lightspeed-service/tree/main/ols/user_data_collection#how-to-test-locally

@openshift-ci
Copy link

openshift-ci bot commented Aug 20, 2025

@onmete: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.18-e2e-ols-cluster 831a694 link true /test 4.18-e2e-ols-cluster

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@onmete
Copy link
Contributor Author

onmete commented Sep 3, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2025
@onmete
Copy link
Contributor Author

onmete commented Sep 8, 2025

obsolete

@onmete onmete closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants