Skip to content

TRT-2163: incluster disruption images #30007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

neisw
Copy link
Contributor

@neisw neisw commented Jul 21, 2025

Hitting issues running oc adm release info on upi and disconnected clusters. Looking to reuse OTE based ExtractImageFromReleasePayload

Solution AI assisted by Cursor, Real I by @stbenjam

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2025
Copy link
Contributor

openshift-ci bot commented Jul 21, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2025
@neisw
Copy link
Contributor Author

neisw commented Jul 21, 2025

/test e2e-metal-ipi-ovn-ipv6

@neisw
Copy link
Contributor Author

neisw commented Jul 21, 2025

/test e2e-metal-ipi-ovn-ipv6

Copy link

openshift-trt bot commented Jul 21, 2025

Job Failure Risk Analysis for sha: eafd5e4

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (15) are below the historical average (2550): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@neisw neisw force-pushed the trt-2163-incluster-disruption-images branch from eafd5e4 to 45ab2d9 Compare July 21, 2025 23:11
@neisw
Copy link
Contributor Author

neisw commented Jul 21, 2025

/test e2e-metal-ipi-ovn-ipv6

@neisw neisw force-pushed the trt-2163-incluster-disruption-images branch from 45ab2d9 to 3807fc1 Compare July 22, 2025 11:11
@neisw
Copy link
Contributor Author

neisw commented Jul 22, 2025

/test ci/prow/e2e-gcp-ovn-upgrade
/test ci/prow/e2e-metal-ipi-serial-1of2

Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

@neisw: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-jenkins
/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-image-registry
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-ovn
/test e2e-gcp-ovn-builds
/test e2e-gcp-ovn-image-ecosystem
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi
/test images
/test lint
/test okd-scos-images
/test unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-agnostic-ovn-cmd
/test e2e-aws-csi
/test e2e-aws-disruptive
/test e2e-aws-etcd-certrotation
/test e2e-aws-etcd-recovery
/test e2e-aws-ovn
/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-etcd-scaling
/test e2e-aws-ovn-kube-apiserver-rollout
/test e2e-aws-ovn-kubevirt
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-ipsec
/test e2e-aws-ovn-serial-publicnet-1of2
/test e2e-aws-ovn-serial-publicnet-2of2
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-single-node-serial
/test e2e-aws-ovn-single-node-techpreview
/test e2e-aws-ovn-single-node-techpreview-serial
/test e2e-aws-ovn-single-node-upgrade
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-upgrade-rollback
/test e2e-aws-ovn-upi
/test e2e-aws-proxy
/test e2e-azure
/test e2e-azure-ovn-etcd-scaling
/test e2e-azure-ovn-upgrade
/test e2e-baremetalds-kubevirt
/test e2e-external-aws
/test e2e-external-aws-ccm
/test e2e-external-vsphere-ccm
/test e2e-gcp-csi
/test e2e-gcp-disruptive
/test e2e-gcp-fips-serial-1of2
/test e2e-gcp-fips-serial-2of2
/test e2e-gcp-ovn-etcd-scaling
/test e2e-gcp-ovn-rt-upgrade
/test e2e-gcp-ovn-techpreview
/test e2e-gcp-ovn-techpreview-serial-1of2
/test e2e-gcp-ovn-techpreview-serial-2of2
/test e2e-gcp-ovn-usernamespace
/test e2e-hypershift-conformance
/test e2e-metal-ipi-ovn
/test e2e-metal-ipi-ovn-bgp-virt-dualstack
/test e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
/test e2e-metal-ipi-ovn-dualstack-local-gateway
/test e2e-metal-ipi-ovn-kube-apiserver-rollout
/test e2e-metal-ipi-serial-1of2
/test e2e-metal-ipi-serial-2of2
/test e2e-metal-ipi-serial-ovn-ipv6-1of2
/test e2e-metal-ipi-serial-ovn-ipv6-2of2
/test e2e-metal-ipi-virtualmedia
/test e2e-metal-ovn-single-node-live-iso
/test e2e-metal-ovn-single-node-with-worker-live-iso
/test e2e-metal-ovn-two-node-arbiter
/test e2e-metal-ovn-two-node-fencing
/test e2e-openstack-ovn
/test e2e-openstack-serial
/test e2e-vsphere-ovn-dualstack-primaryv6
/test e2e-vsphere-ovn-etcd-scaling
/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-main-e2e-agnostic-ovn-cmd
pull-ci-openshift-origin-main-e2e-aws-csi
pull-ci-openshift-origin-main-e2e-aws-disruptive
pull-ci-openshift-origin-main-e2e-aws-ovn
pull-ci-openshift-origin-main-e2e-aws-ovn-cgroupsv2
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones
pull-ci-openshift-origin-main-e2e-aws-ovn-etcd-scaling
pull-ci-openshift-origin-main-e2e-aws-ovn-fips
pull-ci-openshift-origin-main-e2e-aws-ovn-kube-apiserver-rollout
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2
pull-ci-openshift-origin-main-e2e-aws-ovn-single-node
pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-serial
pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-upgrade
pull-ci-openshift-origin-main-e2e-aws-ovn-upgrade
pull-ci-openshift-origin-main-e2e-aws-proxy
pull-ci-openshift-origin-main-e2e-azure
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling
pull-ci-openshift-origin-main-e2e-azure-ovn-upgrade
pull-ci-openshift-origin-main-e2e-gcp-csi
pull-ci-openshift-origin-main-e2e-gcp-disruptive
pull-ci-openshift-origin-main-e2e-gcp-fips-serial-1of2
pull-ci-openshift-origin-main-e2e-gcp-fips-serial-2of2
pull-ci-openshift-origin-main-e2e-gcp-ovn
pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling
pull-ci-openshift-origin-main-e2e-gcp-ovn-rt-upgrade
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview-serial-1of2
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview-serial-2of2
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade
pull-ci-openshift-origin-main-e2e-hypershift-conformance
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack-local-gateway
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-kube-apiserver-rollout
pull-ci-openshift-origin-main-e2e-metal-ipi-serial-1of2
pull-ci-openshift-origin-main-e2e-metal-ipi-serial-2of2
pull-ci-openshift-origin-main-e2e-metal-ipi-serial-ovn-ipv6-1of2
pull-ci-openshift-origin-main-e2e-metal-ipi-serial-ovn-ipv6-2of2
pull-ci-openshift-origin-main-e2e-metal-ipi-virtualmedia
pull-ci-openshift-origin-main-e2e-openstack-ovn
pull-ci-openshift-origin-main-e2e-openstack-serial
pull-ci-openshift-origin-main-e2e-vsphere-ovn
pull-ci-openshift-origin-main-e2e-vsphere-ovn-dualstack-primaryv6
pull-ci-openshift-origin-main-e2e-vsphere-ovn-etcd-scaling
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi
pull-ci-openshift-origin-main-images
pull-ci-openshift-origin-main-lint
pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn
pull-ci-openshift-origin-main-okd-scos-images
pull-ci-openshift-origin-main-unit
pull-ci-openshift-origin-main-verify
pull-ci-openshift-origin-main-verify-deps

In response to this:

/test ci/prow/e2e-gcp-ovn-upgrade
/test ci/prow/e2e-metal-ipi-serial-1of2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@neisw
Copy link
Contributor Author

neisw commented Jul 22, 2025

/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-serial-1of2

@neisw
Copy link
Contributor Author

neisw commented Jul 23, 2025

/test e2e-vsphere-ovn-upi

@neisw
Copy link
Contributor Author

neisw commented Jul 23, 2025

/test e2e-metal-ipi-ovn-ipv6

@neisw neisw marked this pull request as ready for review July 23, 2025 23:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2025
@openshift-ci openshift-ci bot requested review from deads2k and sjenning July 23, 2025 23:21
@neisw
Copy link
Contributor Author

neisw commented Jul 23, 2025

/test e2e-vsphere-ovn-upi
/test e2e-metal-ipi-ovn-ipv6

@neisw
Copy link
Contributor Author

neisw commented Jul 23, 2025

/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-upi-serial

Copy link
Contributor

openshift-ci bot commented Jul 23, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-upi-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e2ea3190-681b-11f0-9cf4-87493d34870b-0

@neisw
Copy link
Contributor Author

neisw commented Jul 24, 2025

/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade 10

Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/14f8a930-6823-11f0-9ed7-ff6e67bb013d-0

@neisw
Copy link
Contributor Author

neisw commented Jul 24, 2025

/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade 10

Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cc02c4c0-68dd-11f0-9b99-a1c057409273-0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, the helpers that are used outside the extension code might be better suited to go somewhere like test/extended/util/payload.go

Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 28, 2025
@neisw neisw force-pushed the trt-2163-incluster-disruption-images branch from e1eb464 to 357f954 Compare July 28, 2025 19:09
@vrutkovs
Copy link
Member

/jira refresh
/lgtm

@openshift-ci-robot
Copy link

@vrutkovs: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2025
Copy link
Contributor

openshift-ci bot commented Jul 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs
Copy link
Member

vrutkovs commented Jul 29, 2025

/retitle TRT-2163: incluster disruption images

@openshift-ci openshift-ci bot changed the title Trt 2163 incluster disruption images TRT-2163: incluster disruption images Jul 29, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 29, 2025

@neisw: This pull request references TRT-2163 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Hitting issues running oc adm release info on upi and disconnected clusters. Looking to reuse OTE based ExtractImageFromReleasePayload

Solution AI assisted by Cursor, Real I by @stbenjam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5ef42f5 and 2 for PR HEAD 357f954 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 82cfbea and 2 for PR HEAD 357f954 in total

@neisw
Copy link
Contributor Author

neisw commented Jul 30, 2025

/retest-required

Copy link

openshift-trt bot commented Jul 30, 2025

Job Failure Risk Analysis for sha: 357f954

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling IncompleteTests
Tests for this run (26) are below the historical average (1779): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-azure-ovn-upgrade Medium
Job run should complete before timeout
This test has passed 95.22% of 4102 runs on release 4.20 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-gcp-disruptive IncompleteTests
Tests for this run (32) are below the historical average (122): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Copy link

openshift-trt bot commented Jul 30, 2025

Job Failure Risk Analysis for sha: 357f954

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling IncompleteTests
Tests for this run (26) are below the historical average (1779): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-azure-ovn-upgrade Medium
Job run should complete before timeout
This test has passed 95.14% of 4092 runs on release 4.20 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-gcp-disruptive IncompleteTests
Tests for this run (32) are below the historical average (122): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@vrutkovs
Copy link
Member

/retest-required

@vrutkovs
Copy link
Member

/test e2e-aws-ovn-microshift

@neisw
Copy link
Contributor Author

neisw commented Jul 30, 2025

/override ci/prow/e2e-aws-ovn-microshift
/skip

passed on the same commit earlier, failures seen outside of pr

Copy link
Contributor

openshift-ci bot commented Jul 30, 2025

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-ovn-microshift

In response to this:

/override ci/prow/e2e-aws-ovn-microshift
/skip

passed on the same commit earlier, failures seen outside of pr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-trt bot commented Jul 30, 2025

Job Failure Risk Analysis for sha: 357f954

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling IncompleteTests
Tests for this run (26) are below the historical average (1766): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-azure-ovn-upgrade Medium
Job run should complete before timeout
This test has passed 95.18% of 4127 runs on release 4.20 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-gcp-disruptive IncompleteTests
Tests for this run (32) are below the historical average (120): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Copy link
Contributor

openshift-ci bot commented Jul 30, 2025

@neisw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-serial 357f954 link false /test e2e-openstack-serial
ci/prow/e2e-aws-ovn-etcd-scaling 357f954 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-etcd-scaling 357f954 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-1of2 357f954 link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-metal-ipi-serial-2of2 357f954 link false /test e2e-metal-ipi-serial-2of2
ci/prow/e2e-azure-ovn-etcd-scaling 357f954 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-2of2 357f954 link false /test e2e-gcp-fips-serial-2of2
ci/prow/e2e-aws-disruptive 357f954 link false /test e2e-aws-disruptive
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 357f954 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 357f954 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node-upgrade 357f954 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-ovn-techpreview-serial-2of2 357f954 link false /test e2e-gcp-ovn-techpreview-serial-2of2
ci/prow/e2e-azure-ovn-upgrade 357f954 link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-gcp-disruptive 357f954 link false /test e2e-gcp-disruptive
ci/prow/e2e-vsphere-ovn-etcd-scaling 357f954 link false /test e2e-vsphere-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-trt bot commented Jul 30, 2025

Job Failure Risk Analysis for sha: 357f954

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling IncompleteTests
Tests for this run (26) are below the historical average (1759): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-azure-ovn-upgrade Medium
Job run should complete before timeout
This test has passed 95.25% of 4193 runs on release 4.20 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-gcp-disruptive IncompleteTests
Tests for this run (32) are below the historical average (119): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 851e33d and 1 for PR HEAD 357f954 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 867bce8 into openshift:main Jul 30, 2025
57 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.20.0-202507302114.p0.g867bce8.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants