OCPBUGS-48186: Add kubelet and CRI-O panic detection invariant test #30243
Conversation
PannagaRao
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 7570b8a
|
openshift-merge-robot
added
the
needs-rebase
PannagaRao
force-pushed
the
monitor-test-panic
branch
from
7570b8a to
d468333
Compare
openshift-merge-robot
removed
the
needs-rebase
PannagaRao
force-pushed
the
monitor-test-panic
branch
from
fc65ad1 to
e2aae7e
Compare
|
Job Failure Risk Analysis for sha: e2aae7e
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: e2aae7e
|
PannagaRao
force-pushed
the
monitor-test-panic
branch
from
e2aae7e to
973a936
Compare
|
/test-with openshift/kubernetes#2468 |
|
/test e2e-aws-ovn-fips |
|
/test e2e-aws-ovn-fips --from openshift/kubernetes#2468 |
|
/test e2e-aws-ovn-fips --from=openshift/kubernetes#2468 |
|
Job Failure Risk Analysis for sha: 973a936
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 973a936
|
|
/payload-job-with-prs e2e-aws-ovn-fips openshift/kubernetes#2468 |
|
@PannagaRao: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0915cc20-94aa-11f0-86a6-18150b14e243-0 |
|
/payload-job-with-prs e2e-aws-ovn-fips openshift/kubernetes#2468 |
|
@PannagaRao: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-job-with-prs e2e-aws-ovn-fips openshift/kubernetes#2468 |
|
@PannagaRao: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/148ed9e0-94d0-11f0-9cf6-f13decee80c1-0 |
|
Confirmed that the panic gets detected by simulating a kubelet panic for testing purposes |
PannagaRao
force-pushed
the
monitor-test-panic
branch
from
973a936 to
dafc915
Compare
|
/payload-job-with-prs e2e-aws-ovn-fips openshift/kubernetes#2468 |
|
@PannagaRao: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
Job Failure Risk Analysis for sha: 9d16343
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 9d16343
New tests seen in this PR at sha: 9d16343
|
|
Job Failure Risk Analysis for sha: 9d16343
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 9d16343
New tests seen in this PR at sha: 9d16343
|
openshift-merge-robot
added
the
needs-rebase
|
Job Failure Risk Analysis for sha: 9d16343
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 9d16343
New tests seen in this PR at sha: 9d16343
|
PannagaRao
force-pushed
the
monitor-test-panic
branch
from
9d16343 to
146e59e
Compare
openshift-ci-robot
removed
the
verified
openshift-merge-robot
removed
the
needs-rebase
|
New changes are detected. LGTM label has been removed. |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 146e59e
|
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 146e59e
|
|
cc @dgoodwin I know that TRT was interested in improving panic detection. Curious if you all could help review? |
|
@PannagaRao can you fix the go fmt failures? |
Signed-off-by: Pannaga Rao Bhoja Ramamanohara
PannagaRao
force-pushed
the
monitor-test-panic
branch
2 times, most recently
from
00d170a to
9a37149
Compare
|
/retest |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 9a37149
New tests seen in this PR at sha: 9a37149
|
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 9a37149
New tests seen in this PR at sha: 9a37149
|
| errCh <- err | ||
| return | ||
| } | ||
| newCrioLogs := eventsFromCrioLogs(nodeName, crioLogs) |
There was a problem hiding this comment.
Nit: I was tripped up at first by 'newCrioLogs' whereas the others would follow 'newCrioInterval' / 'newCrioEvents'
There was a problem hiding this comment.
Changed it to newCrioEvents.
| Locator(nodeLocator). | ||
| Message(monitorapi.NewMessage(). | ||
| Reason(reason). | ||
| HumanMessage(human)). |
There was a problem hiding this comment.
Looks like the junit references locator so likely not an issue but just noting that other messages in here include the nodeName as well
monitorapi.NewMessage().Reason(reason).Node(nodeName).HumanMessage(message),
There was a problem hiding this comment.
It's redundant since the node is already in the locator, I tried keeping it consistent with other node-level functions in this file.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DennisPeriquet, haircommander, neisw, PannagaRao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Pannaga Rao Bhoja Ramamanohara
PannagaRao
force-pushed
the
monitor-test-panic
branch
from
009196d to
93e2bfb
Compare
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 93e2bfb
|
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 93e2bfb
|
|
@PannagaRao: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 93e2bfb
New tests seen in this PR at sha: 93e2bfb
|
7 participants
Signed-off-by: Pannaga Rao Bhoja Ramamanohara