Cleanup & Suggestions #178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all. I'd like to suggest a few changes, each detailed in individual commits below. Most of them are pretty minor, but I kept them separate for readability's sake.
The only changes that are likely controversial are:
Removing
requirements.txt
in favor of inlining the contents ofinstall_requires
. Given that DRF is the only requirement, the file inclusion/parsing seems like overkill.Removing the DRF version bounds. From the commit message:
It might be worth adding a note along the lines of "djangorestframework-gis is generally compatible with modern versions of Django REST Framework, however it's only explicitly tested against the latest version of DRF at the time of release, indicated in the compatibility matrix below."
Edit: it looks like there was a compatibility issue when upgrading DRF 3.9. I don't fully understand the issue, but my understanding is that it was related to test output only, and doesn't reflect a change in compatibility or expected output from djangorestframework-gis.