[urls] Fix namespace conflicts in API container #241 #511
+21
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both dashboard and API containers were using same namespaces causing Django warnings. Added prefix param to openwisp_controller_urls() and changed firmware namespace in API to avoid conflicts. Fixes openwisp#241
- Changed single quotes to double quotes - Added trailing comma for black formatter Fixes openwisp#241
|
The QA formatting issues have been resolved.but the build is |
nemesifier
reviewed
Oct 10, 2025
There was a problem hiding this comment.
Before sending PRs, please verify there's a real issue, see:
#241 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both dashboard and API containers were using same namespaces causing Django warnings. Added prefix param to openwisp_controller_urls() and changed firmware namespace in API to avoid conflicts.
Fixes #241
Checklist
Reference to Existing Issue
Closes #241.
Description of Changes
openwisp_controller_urls()functionapi-firmwarenamespace instead offirmwareapiprefix to controller URLs in API container to avoid IPAM conflictsTesting
Screenshot
Please include any relevant screenshots.
