Skip to content

Bugfix for create evaluation API #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Bugfix for create evaluation API #1010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dfa556
Create eval bugfix
kumar-shivam-ranjan Nov 20, 2024
2cbe281
Fix the eval for chat models
mrDzurb Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ads/aqua/evaluation/entities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class CreateAquaEvaluationDetails(Serializable):
ocpus: Optional[float] = None
log_group_id: Optional[str] = None
log_id: Optional[str] = None
metrics: Optional[List[str]] = None
metrics: Optional[List[Dict[str, Any]]] = None
force_overwrite: Optional[bool] = False

class Config:
Expand Down Expand Up @@ -140,7 +140,7 @@ class AquaEvaluationCommands(Serializable):
evaluation_id: str
evaluation_target_id: str
input_data: Dict[str, Any]
metrics: List[str]
metrics: List[Dict[str, Any]]
output_dir: str
params: Dict[str, Any]

Expand Down
8 changes: 2 additions & 6 deletions ads/aqua/evaluation/evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ def create(
create_aqua_evaluation_details = CreateAquaEvaluationDetails(**kwargs)
except Exception as ex:
custom_errors = {
".".join(map(str, e["loc"])): e["msg"] for e in json.loads(ex.json())
".".join(map(str, e["loc"])): e["msg"]
for e in json.loads(ex.json())
}
raise AquaValueError(
f"Invalid create evaluation parameters. Error details: {custom_errors}."
Expand Down Expand Up @@ -619,11 +620,6 @@ def _build_launch_cmd(
evaluation_id=evaluation_id,
evaluation_target_id=evaluation_source_id,
input_data={
"columns": {
"prompt": "prompt",
"completion": "completion",
"category": "category",
},
"format": Path(dataset_path).suffix,
"url": dataset_path,
},
Expand Down