Fix config load paths and update ads version #1056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR #1053 introduced a bug in the code that loads configuration files for finetuning and deployment. The issue was that the structure of the models without service tag is inconsistent, and the code didn't account for this. The fix for this is to check the parent directory of the artifact folder first (in case of verified models), and then check the artifact directory (for unverified models).
Test Cases
The following applies to both
ft_config.jsonanddeployment_config.json.oci://service-managed-models@<namespace>/service_models/Mistral-7B-Instruct-v0.1/3dc28cf/config/ft_config.jsonoci://service-managed-models@<namespace>/service_models/gemma-2b-it/de144fb/config/deployment_config.jsonoci://user-bucket@<namespace>/aqua/models/BAAI/bge-m3/config/deployment_config.jsonconfigfolder in the user bucket as per instructions here, and the API will return the respective configs.The above also applies to deploying fine-tuned models as the verified models will have the "aqua_service_model" tag, hence it will always refer to the base model configs for deployment.