Skip to content

Conversation

@VipulMascarenhas
Copy link
Member

@VipulMascarenhas VipulMascarenhas commented Feb 4, 2025

Description

The PR #1053 introduced a bug in the code that loads configuration files for finetuning and deployment. The issue was that the structure of the models without service tag is inconsistent, and the code didn't account for this. The fix for this is to check the parent directory of the artifact folder first (in case of verified models), and then check the artifact directory (for unverified models).

Test Cases

The following applies to both ft_config.json and deployment_config.json.

  1. Config for cached verified models
    • model will not have "aqua_service_model" tag, hence artifact path will be set to the service bucket location.
    • Example: oci://service-managed-models@<namespace>/service_models/Mistral-7B-Instruct-v0.1/3dc28cf/config/ft_config.json
  2. Config for uncached and registered verified models
    • model will have the "aqua_service_model" tag, so base model's artifact path will be used, which in turn refers to the service bucket location.
    • Example: oci://service-managed-models@<namespace>/service_models/gemma-2b-it/de144fb/config/deployment_config.json
  3. Config for unverified models
    • model will not have "aqua_service_model" tag, hence artifact path will be set to the location of user's bucket.
    • Example: oci://user-bucket@<namespace>/aqua/models/BAAI/bge-m3/config/deployment_config.json
    • The config file does not exist by default, hence the API return an empty dict. If user prefers to add their own config, they can add it in the config folder in the user bucket as per instructions here, and the API will return the respective configs.

The above also applies to deploying fine-tuned models as the verified models will have the "aqua_service_model" tag, hence it will always refer to the base model configs for deployment.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 4, 2025
@github-actions
Copy link

github-actions bot commented Feb 4, 2025

⚠️ This PR changed pyproject.toml file. ⚠️

  • PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
  • PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

@github-actions
Copy link

github-actions bot commented Feb 4, 2025

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-56.76%

@VipulMascarenhas VipulMascarenhas merged commit 7ce9342 into main Feb 4, 2025
23 checks passed
@VipulMascarenhas VipulMascarenhas deleted the aqua_config_hot_fix branch February 4, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants