Skip to content

[Multi model deployment] Updating usages for container config #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025
Merged

[Multi model deployment] Updating usages for container config #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
422a18f
Updating multi model deployment usages
kumar-shivam-ranjan Apr 2, 2025
2058aa1
Addressing review comments
kumar-shivam-ranjan Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ads/aqua/config/container_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ class Usage(ExtendedEnum):
INFERENCE = "inference"
BATCH_INFERENCE = "batch_inference"
MULTI_MODEL = "multi_model"
OTHER = "other"


class AquaContainerConfigSpec(Serializable):
Expand Down
5 changes: 4 additions & 1 deletion ads/aqua/model/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,10 @@ def create_multi(
supported_container_families = [
container_config_item.family
for container_config_item in service_inference_containers
if Usage.MULTI_MODEL in container_config_item.usages
if any(
usage in container_config_item.usages
for usage in [Usage.MULTI_MODEL, Usage.OTHER]
)
]

if not supported_container_families:
Expand Down
5 changes: 4 additions & 1 deletion ads/aqua/modeldeployment/deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,10 @@ def create(
supported_container_families = [
container_config_item.family
for container_config_item in service_inference_containers
if Usage.MULTI_MODEL in container_config_item.usages
if any(
usage in container_config_item.usages
for usage in [Usage.MULTI_MODEL, Usage.OTHER]
)
]

if not supported_container_families:
Expand Down
2 changes: 2 additions & 0 deletions tests/unitary/with_extras/aqua/test_data/ui/container_index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@
],
"type": "inference",
"usages": [
"inference",
"batch_inference",
"multi_model"
],
"version": "0.4.1.3"
Expand Down
2 changes: 1 addition & 1 deletion tests/unitary/with_extras/aqua/test_ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ def test_list_containers(self, mock_get_container_config):
],
"server_port": "8080",
},
"usages": ["multi_model"],
"usages": ["inference", "batch_inference", "multi_model"],
},
],
"finetune": [
Expand Down