[GR-62124] Remove jdk.graal.compiler dependency on org.graalvm.nativeimage. #10863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handle class renaming or deletion (e.g. HotSpotDisassemblerProvider)
oracle-contributor-agreement
bot
added
the
OCA Verified
dougxc
reviewed
Mar 17, 2025
| var s = suggestions.entrySet().stream().map(e -> e.getValue().stream().map(v -> "-H:AbortOn" + e.getKey() + "Reachable" + "=" + v).collect(Collectors.joining(sep))).collect( | ||
| Collectors.joining(sep)); | ||
| String anno = HostedOnly.class.getSimpleName(); | ||
| throw new IllegalArgumentException("@" + anno + " annotated elements reached. Add following Native Image flags to see why they are reachable:" + sep + s); |
There was a problem hiding this comment.
Sample output:
[libjvmcicompiler.dylib:71997] Internal exception: com.oracle.svm.core.util.UserError$UserException: Feature defined by jdk.graal.compiler.libgraal.LibGraalFeature unexpectedly failed with a(n) java.lang.IllegalArgumentException. Please report this problem to the authors of jdk.graal.compiler.libgraal.LibGraalFeature.
[libjvmcicompiler.dylib:71997] at org.graalvm.nativeimage.builder/com.oracle.svm.core.util.UserError.abort(UserError.java:97)
[libjvmcicompiler.dylib:71997] at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.FeatureHandler.handleFeatureError(FeatureHandler.java:306)
[libjvmcicompiler.dylib:71997] at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.FeatureHandler.forEachFeature(FeatureHandler.java:95)
[libjvmcicompiler.dylib:71997] at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGenerator.runPointsToAnalysis(NativeImageGenerator.java:857)
[libjvmcicompiler.dylib:71997] at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:571)
[libjvmcicompiler.dylib:71997] at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGenerator.run(NativeImageGenerator.java:537)
[libjvmcicompiler.dylib:71997] at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.buildImage(NativeImageGeneratorRunner.java:545)
[libjvmcicompiler.dylib:71997] at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.build(NativeImageGeneratorRunner.java:731)
[libjvmcicompiler.dylib:71997] at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.start(NativeImageGeneratorRunner.java:151)
[libjvmcicompiler.dylib:71997] at org.graalvm.nativeimage.builder/com.oracle.svm.hosted.NativeImageGeneratorRunner.main(NativeImageGeneratorRunner.java:99)
[libjvmcicompiler.dylib:71997] Caused by: java.lang.IllegalArgumentException: @HostedOnly annotated elements reached. Add following Native Image flags to see why they are reachable:
[libjvmcicompiler.dylib:71997] -H:AbortOnFieldReachable=jdk.graal.compiler.graph.NodeFlood.totalMarkedCount
[libjvmcicompiler.dylib:71997] -H:AbortOnFieldReachable=jdk.graal.compiler.graph.NodeFlood.worklist
[libjvmcicompiler.dylib:71997] -H:AbortOnMethodReachable=jdk.graal.compiler.graph.NodeInputList.NodeInputList
[libjvmcicompiler.dylib:71997] -H:AbortOnMethodReachable=jdk.graal.compiler.graph.NodeSourcePosition.trim
[libjvmcicompiler.dylib:71997] -H:AbortOnTypeReachable=jdk.graal.compiler.graph.SuccessorEdges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the last dependency of jargraal on Native Image API. Major changes:
LibGraalSupport.HostedOnlyannotation that serves the same purpose as@Platforms(Platform.HOSTED_ONLY.class). Ideally the error message would show the causality stack for how the element was reached but this causality info is not available to a reachability handler. The compromise solution is shown here.ImageInfo.inImage[Build|Run]timeCodewithLibGraalSupport.inLibGraalRuntimeandNativeImageSupport.in[Build|Run]timeCode.Minor changes piggy backed here:
SnippetResolvedJavaType.methodsfromList<SnippetResolvedJavaMethod>toSnippetResolvedJavaMethod[].artifactIdattribute forNATIVEIMAGE_LIBGRAAL.OptionValueaccess on assertion-only branch into assertion condition.