[GR-64209] Adopt attach API changes and fix @BasedOnJDKFile annotations. #11038
+294
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
chaeubl/GR-64209
branch
from
c4eb5c9 to
b34be39
Compare
roberttoyonaga
approved these changes
Apr 15, 2025
|
|
||
| int optionStart = nameAndOptions.indexOf(' '); | ||
| if (optionStart != -1) { | ||
| name = nameAndOptions.substring(0, optionStart); |
There was a problem hiding this comment.
It doesn't hurt to do this check, but I think we could also just assume there will never be any options specified by the client. Because at this point it has already asked the server "getversion" and knows it doesn't support options, so it shouldn't supply any. We could possibly even return a "not supported" warning message if we somehow end up in this branch.
There was a problem hiding this comment.
Good point - I will probably keep the check for now though (it makes the diff against HotSpot a bit smaller).
graalvmbot
force-pushed
the
chaeubl/GR-64209
branch
from
b34be39 to
3986c6e
Compare
graalvmbot
force-pushed
the
chaeubl/GR-64209
branch
from
3986c6e to
c30710e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the attach API from
JDK-24+18toJDK-25+18(except for any functionality related to version 2 andstreaming, which are both not supported at the moment).