[GR-67833] Improve -XX:FlightRecorderLogging error message for unknown tag set

[graalvmbot]

A documentation issue in JRF.md indicated that we should improve our error messages for unknown tag sets for -XX:FlightRecorderLogging. Previously, we would have printed the following:

$ ./svmbuild/helloworld -XX:StartFlightRecording="filename=recording.jfr,dumponexit=true" -XX:FlightRecorderLogging=jfr,system=debug
Uncaught exception while running isolate initialization hooks:
java.lang.IllegalArgumentException: No tag set matches tag combination [system] for FlightRecorderLogging
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.jfr.logging.JfrLogConfiguration.verifySelections(JfrLogConfiguration.java:96)
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.jfr.logging.JfrLogConfiguration.parse(JfrLogConfiguration.java:75)
...

For comparison, Hotspot prints the following warning:

$ java -Xlog:jfr,system=debug --version
[0.000s][warning][logging] No tag set matches selection: system. Did you mean any of the following? system* jfr+system* jfr+system+streaming jfr+system+metadata jfr+system+periodic
...

With this PR, we also suggest valid tag combinations. A few examples:

$ ./svmbuild/helloworld -XX:StartFlightRecording="filename=recording.jfr,dumponexit=true" -XX:FlightRecorderLogging=jfr,system=debug
Uncaught exception while running isolate initialization hooks:
java.lang.IllegalArgumentException: No tag set matches tag combination [system] for FlightRecorderLogging. Did you mean any of the following? jfr+system jfr+system+event jfr+system+setting jfr+system+bytecode jfr+system+parser jfr+system+metadata jfr+system+streaming jfr+system+throttle jfr+system+periodic jfr+system+sampling
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.jfr.logging.JfrLogConfiguration.verifySelections(JfrLogConfiguration.java:113)
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.jfr.logging.JfrLogConfiguration.parse(JfrLogConfiguration.java:75)
...

We only print suggestions that match all provided tags:

$ ./svmbuild/helloworld -XX:StartFlightRecording="filename=recording.jfr,dumponexit=true" -XX:FlightRecorderLogging=jfr,system+periodic=debug
Uncaught exception while running isolate initialization hooks:
java.lang.IllegalArgumentException: No tag set matches tag combination [system, periodic] for FlightRecorderLogging. Did you mean any of the following? jfr+system+periodic
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.jfr.logging.JfrLogConfiguration.verifySelections(JfrLogConfiguration.java:113)
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.jfr.logging.JfrLogConfiguration.parse(JfrLogConfiguration.java:75)
...

For completely unknown tags, we don't print any suggestions (same as before):

$ ./svmbuild/helloworld -XX:StartFlightRecording="filename=recording.jfr,dumponexit=true" -XX:FlightRecorderLogging=jfr,unknown_tag=debug
Uncaught exception while running isolate initialization hooks:
java.lang.IllegalArgumentException: Invalid log tag 'unknown_tag' for FlightRecorderLogging.
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.jfr.logging.JfrLogConfiguration$JfrLogSelection.parse(JfrLogConfiguration.java:178)
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.jfr.logging.JfrLogConfiguration.parse(JfrLogConfiguration.java:72)
...

[roberttoyonaga]

This is a nice improvement. Looks good to me!

[zapster]

Thanks for the review, @roberttoyonaga!