Skip to content

Conversation

stooke
Copy link
Contributor

@stooke stooke commented Mar 10, 2020

This PR is for an initial implementation of debug support for Graal on Windows. At this stage I submit it more for discussion before I go much further down this road.

The patch allows Graal to emit CodeView 4 records into windows .obj files, which the windows linker then moves to PDB files at link time. Visual Studio can then open the executable, breakpoints can be set, and single-steping, etc. will work.

Variables, and type information are not currently supported, and there is limited support for stack frames.

I work closely with Andrew Dinn @adinn on debug support, so my code makes use of his previous work; I duplicate some of the shared classes from his PR here.

There are some differences in how I approach line information, but these are currently compile-time switches. For more details, please see DEBUGINFO_WINDOWS.md.

adinn added 30 commits January 21, 2020 17:11
…th for use when debugging native image with gdb
@olpaw
Copy link
Member

olpaw commented Apr 7, 2020

Since @adinn s PR is on master you will have to rebase your PR against latest master (i.e. rebase https://github.com/stooke/graal/tree/pr_debug_pecoff_prototype to https://github.com/oracle/graal/)
Sorry for the inconvenience.

stooke added 24 commits April 7, 2020 08:49
@stooke
Copy link
Contributor Author

stooke commented Apr 23, 2020

Since @adinn s PR is on master you will have to rebase your PR against latest master (i.e. rebase https://github.com/stooke/graal/tree/pr_debug_pecoff_prototype to https://github.com/oracle/graal/)
Sorry for the inconvenience.

A full rebase is not going well - too many conflicts (this could be my inexperience with rebase). It would be more expedient for me to open a new PR using a repo cloned directly from github/oracle instead of github/adinn. Is that okay?

@olpaw
Copy link
Member

olpaw commented Apr 24, 2020

It would be more expedient for me to open a new PR using a repo cloned directly from github/oracle instead of github/adinn. Is that okay?

Whatever works best for you is fine with us.

@stooke
Copy link
Contributor Author

stooke commented Apr 24, 2020

I have created PR #2396 to replace this, with a properly rebased and cleaned up commit history.

@stooke stooke closed this Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants