Skip to content

Conversation

Noisyfox
Copy link
Contributor

This PR adds basic support for encoding AArch64 relocations currently used by GraalVM in Mach-O file.

Mach-O requires to use ARM64_RELOC_ADDEND for encoding addend for certain relocation types:
https://opensource.apple.com/source/ld64/ld64-274.2/src/ld/parsers/macho_relocatable_file.cpp.auto.html

@Noisyfox
Copy link
Contributor Author

This patch is already used in the development of our iOS framework and it's working fine so far.

@graalvmbot
Copy link
Collaborator

Hello Noisyfox, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address timemanager -(dot)- rick -(at)- gmail -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

@teshull teshull self-assigned this Aug 30, 2021
@teshull
Copy link
Member

teshull commented Oct 15, 2021

Hi @Noisyfox. Thanks for the PR. I made a follow up PR which adds the same relocation logic, but also cleans up the relocation information some.

Can you confirm that #3864 works for your use case?

@Noisyfox
Copy link
Contributor Author

@teshull Yeah that looks good to me~ Thanks~

@graalvmbot
Copy link
Collaborator

Hello Noisyfox, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address timemanager -(dot)- rick -(at)- gmail -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

@Noisyfox Noisyfox closed this Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants