Skip to content

Conversation

graalvmbot
Copy link
Collaborator

Implements sealed classes support for JDK17+
Fixes #3870

@graalvmbot graalvmbot force-pushed the github/lazar-mitrovic/GR-34703/sealed-class-support branch 6 times, most recently from 88b3ccb to 0042c73 Compare November 10, 2021 14:15
@graalvmbot graalvmbot force-pushed the github/lazar-mitrovic/GR-34703/sealed-class-support branch 2 times, most recently from fb56e51 to 7eabe5f Compare November 10, 2021 19:14
@graalvmbot graalvmbot force-pushed the github/lazar-mitrovic/GR-34703/sealed-class-support branch 5 times, most recently from f29805a to 0af9ecd Compare November 24, 2021 14:15
}

@AutomaticFeature
final class SealedClassFeatureBeforeJDK17 implements Feature {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be called SealedClassFeatureJDK11OrEarlier for consistency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the naming scheme from RecordFeatureBeforeJDK17, should we change that as well or leave it as is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same concerns, you can change it if you'd like.

break;
}
case "getPermittedSubclasses":
case "isSealed": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing seems to generate a trace event for isSealed, please remove.

@graalvmbot graalvmbot force-pushed the github/lazar-mitrovic/GR-34703/sealed-class-support branch from 0af9ecd to b789dad Compare November 25, 2021 11:00
Add agent support for getPermittedSubclasses
Store permittedSubclasses to reflection data.
@graalvmbot graalvmbot force-pushed the github/lazar-mitrovic/GR-34703/sealed-class-support branch from b789dad to 13bb22c Compare November 26, 2021 00:20
@graalvmbot graalvmbot merged commit d79ae59 into master Nov 27, 2021
@graalvmbot graalvmbot deleted the github/lazar-mitrovic/GR-34703/sealed-class-support branch March 24, 2022 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runtime crash in spring 5.3/spring-native with JDK 17

3 participants