Skip to content

Conversation

ivan-ristovic
Copy link
Contributor

This PR implements runtime relations between modules by transferring hosted module relations to runtime.

Fixes #3911 and addresses #3935

@olpaw olpaw self-requested a review November 5, 2021 13:37
@olpaw olpaw self-assigned this Nov 5, 2021
@olpaw olpaw added this to the 22.0 milestone Nov 5, 2021
@olpaw olpaw changed the title Replicate hosted module relations in runtime boot module layer [GR-34444] Replicate hosted module relations in runtime boot module layer Nov 5, 2021
@olpaw
Copy link
Member

olpaw commented Nov 17, 2021

@ivan-ristovic I ran your PR in our CI and I see gate failures with mx native-unittest --builder-on-modulepath ....
Steps to reproduce on your side:

cd substratevm
mx build
mx gate --omit-clean -t 'native unittests'

This will give you:

...
There were 5 failures:
1) com.oracle.svm.test.jdk11.jfr.TestClassEvent#test
java.lang.IllegalStateException: Can't create Flight Recorder. Unable to make field private static jdk.jfr.internal.handlers.EventHandler jdk.jfr.events.ActiveRecordingEvent.eventHandler accessible: module jdk.jfr does not "opens jdk.jfr.events" to module org.graalvm.nativeimage.builder
	at jdk.jfr.FlightRecorder.getFlightRecorder(FlightRecorder.java:183)
	at jdk.jfr.Recording.<init>(Recording.java:114)
	at jdk.jfr.Recording.<init>(Recording.java:138)
	at com.oracle.svm.test.jdk11.jfr.LocalJFR.startRecording(LocalJFR.java:41)
	at com.oracle.svm.test.jdk11.jfr.TestClassEvent.test(TestClassEvent.java:40)
...
FAILURES!!!
Tests run: 56,  Failures: 5

Please investigate.

@graalvmbot graalvmbot merged commit 3f57011 into oracle:master Nov 27, 2021
graalvmbot pushed a commit that referenced this pull request Sep 12, 2023
PullRequest: truffleruby/3996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GR-34444] Ensure java.lang.Module#isReflectivelyExportedOrOpen works as expected

3 participants