Skip to content

Implementation of GarbageCollection event #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2022
Merged

Implementation of GarbageCollection event #4312

merged 2 commits into from
Feb 17, 2022

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Feb 10, 2022 •
edited
Loading

The patch implements GarbageCollection JFR event.

jdk.GarbageCollection {
  startTime = 12:59:39.673
  duration = 1.148 ms
  gcId = 1
  name = "GenScavenge"
  cause = "java.lang.System.gc()"
  sumOfPauses = 1.148 ms
  longestPause = 1.148 ms
}

The patch also enhances test framework, so that tests can check expected events are actually recorded. And a new TestGCEvents.java is added to verify currently supported GC events.

@zhengyu123 zhengyu123 force-pushed the impl_garbage_collection branch 2 times, most recently from 5f7bff7 to dad28cf Compare February 10, 2022 17:35
@zhengyu123 zhengyu123 force-pushed the impl_garbage_collection branch 2 times, most recently from f74869b to 1657950 Compare February 11, 2022 00:09
@zhengyu123 zhengyu123 marked this pull request as ready for review February 11, 2022 13:16
christianhaeubl
christianhaeubl reviewed Feb 15, 2022
View reviewed changes
@christianhaeubl
Copy link
Member

Thanks for the contribution! I added a few comments.

@zhengyu123 zhengyu123 force-pushed the impl_garbage_collection branch 3 times, most recently from d202097 to c8f0450 Compare February 15, 2022 21:17
@zhengyu123 zhengyu123 force-pushed the impl_garbage_collection branch from c8f0450 to cd76733 Compare February 15, 2022 21:30
@graalvmbot graalvmbot merged commit 5b9d37c into oracle:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christianhaeubl christianhaeubl christianhaeubl left review comments

Assignees

No one assigned

Labels

oca-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhengyu123 @christianhaeubl @graalvmbot