Skip to content

Conversation

graalvmbot
Copy link
Collaborator

and deprecate .build_artifacts.txt files.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 16, 2022
@fniephaus fniephaus requested a review from jerboaa November 16, 2022 07:55
@fniephaus fniephaus self-assigned this Nov 16, 2022
@fniephaus
Copy link
Member

@jerboaa please feel free to take a look at this. We've decided to not include this in the build output JSON because the two files target different consumers: build output for monitoring, build artifacts for packaging tools.
Also note the new (internal) -H:BuildArtifactsJSON option only accepts a path and is inconsistent with -H:BuildOutputJSONFile, which also accepts a filename. I will share more details on how we plan to unified all of this within a public API in the future, would be great to get your feedback on that as well.

Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@jerboaa
Copy link
Collaborator

jerboaa commented Nov 16, 2022

Also note the new (internal) -H:BuildArtifactsJSON option only accepts a path and is inconsistent with -H:BuildOutputJSONFile, which also accepts a filename. I will share more details on how we plan to unified all of this within a public API in the future, would be great to get your feedback on that as well.

OK, looking forward to hear more about this. As long as we have a way of knowing what the produced output filename is (for -HBuildOutputJSONFile) this should be fine.

@fniephaus
Copy link
Member

Thanks for the quick review.

As long as we have a way of knowing what the produced output filename is (for -HBuildOutputJSONFile) this should be fine.

Yes, although we probably won't allow users to customize the filename (easier to unify output and to match against corresponding schema), only the target directory can be changed.

@jerboaa
Copy link
Collaborator

jerboaa commented Nov 16, 2022

Yes, although we probably won't allow users to customize the filename (easier to unify output and to match against corresponding schema), only the target directory can be changed.

Sure, as long as the file name is predictable, say build-output.json within a user-specified directory it would be fine for us. What would be inconvenient is if files end up containing random strings like timestamps or some such. Please consider that, thanks!

@fniephaus
Copy link
Member

Please consider that, thanks!

Sure, will do. Thank you

@graalvmbot graalvmbot force-pushed the fniephaus/GR-42375/build-artifacts branch 3 times, most recently from 6507d99 to 0263d6a Compare November 17, 2022 08:45
@graalvmbot graalvmbot force-pushed the fniephaus/GR-42375/build-artifacts branch from 0263d6a to c5fa2dd Compare December 2, 2022 14:33
@fniephaus
Copy link
Member

Please feel free to take another look, @jerboaa:

  • The option is now a boolean flag. Not sure whether it should be called -H:±BuildArtifacts, -H:±ReportBuildArtifacts, or something else?
  • Paths are now relative again, using uri-reference, which seems to allow relative paths (see here)
  • Since we couldn't identify any external dependents, I disabled the creation of the old file by default and added support for NATIVE_IMAGE_DEPRECATED_BUILD_ARTIFACTS_TXT=true as a temporary fallback

@fniephaus fniephaus changed the title [GR-42375] Introduce -H:BuildArtifactsJSON option. [GR-42375] Introduce -H:±BuildArtifacts option. Dec 2, 2022
@jerboaa
Copy link
Collaborator

jerboaa commented Dec 2, 2022

I'll take a look next week, thanks.

@fniephaus fniephaus changed the title [GR-42375] Introduce -H:±BuildArtifacts option. [GR-42375] Introduce -H:±GenerateBuildArtifactsFile option. Dec 5, 2022
@graalvmbot graalvmbot force-pushed the fniephaus/GR-42375/build-artifacts branch 2 times, most recently from ccb6093 to 4114997 Compare December 5, 2022 17:45
…om.oracle.svm.core into com.oracle.svm.core.util.json
@graalvmbot graalvmbot force-pushed the fniephaus/GR-42375/build-artifacts branch 3 times, most recently from 3570d09 to c55d533 Compare December 12, 2022 13:37
@graalvmbot graalvmbot force-pushed the fniephaus/GR-42375/build-artifacts branch from c55d533 to 6f6ef02 Compare December 13, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants