Object allocation in new TLAB JFR event #5654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Is there any way we can test each JFR event and make sure we don't regress on anything? |
I've added some tests in this internal PR. I have some additional tests for each of the other events I've worked on, including this one, but I've been waiting for that internal PR to be merged before adding them to a new PR to avoid conflicts (there's some shared infrastructure). Those tests only check for correctness though, they don't analyze performance. |
|
Thanks for implementing this event. The changes look good, I will do a few minor cleanups and merge your PR into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This adds support for the JFR event
jdk.ObjectAllocationInNewTLAB. This PR resolves the issue #5636The JFR event
jdk.ObjectAllocationOutsideTLABalso exists, but does not seem applicable to native images because allocations are always done in new TLABs. For example, in Hotspot, if an allocation is larger than the largest possible TLAB size, or if TLAB allocation fails, then allocation is done outside of the TLAB. This is also true if theUseTLABoption is false. However, in SVM, all the aforementioned scenarios still result in using a new TLAB.