[GR-53458] JVMCIVersionCheck should only consider release and early-access OpenJDK version #8791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2269d69.
…cess OpenJDK version
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK builds with different pre-release identifier (
$PRE) do not necessarily use comparable build numbers ($BUILD). Thus, we restrict theJVMCIVersionCheckto known pre-release identifiers, namely empty (a release) andea(used for official early-access builds). Versions with other pre-release identifiers are ignored, i.e., theJVMCVersionCheckwill never complain.This follows-up on #8699, which added general support for checking OpenJDK versions in
JVCMIVersionCheck.See https://openjdk.org/jeps/223 for the official documentation of the versioning scheme.