[GR-54918] Rename JDK23OrLater to JDKLatest and remove obsolete predicates #9211
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
| * Denotes the latest supported JDK version. It corresponds to the highest key in the | ||
| * {@code JVMCI_MIN_VERSIONS} map in {@link jdk.graal.compiler.hotspot.JVMCIVersionCheck}. |
There was a problem hiding this comment.
Would it make sense to move this map in a package that is accessible here and actually reference the highest key instead of hardcoding the check to 21?
There was a problem hiding this comment.
The package is accessible, it is just the field that is private. The LTS version change so seldomly that IMHO it is fine to have a few references to it.
| @Override | ||
| public boolean getAsBoolean() { | ||
| return JavaVersionUtil.JAVA_SPEC <= 22; | ||
| return JavaVersionUtil.JAVA_SPEC > 21; |
There was a problem hiding this comment.
Nitpick: I understand that 21 is used here to avoid having to update the code with each STS JDK release, but this doesn't match the javadoc, nor represents the latest JDK.
There was a problem hiding this comment.
From my perspective, that is just an implementation detail. 21 is the most stable version we have and it only changes once every few years.
3 participants
Currently, exactly two JDK releases are supported: JDK Latest (currently 24) and JDK 21. All other version checks are not needed and cause confusion. Thus, this PR does the following:
JDK22OrEarlierwithJDK21OrEarlierJDK22OrLaterwithJDK23OrLaterJDK23OrLatertoJDKLatestJDKLatestis implemented in a way that we don't need to update the condition for every JDK version bump (boils down toJAVA_SPEC > 21).There are also predicates for JDK 11 and JDK 17. Those are deprecated and unused, but kept for backwards compatibility reasons.