Skip to content

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Jul 5, 2024

This change on top of #8989 re-imports the libsvm_container code from the JDK and adds annotations to keep track of upstream changes. In particular:

  • re-import libsvm_container code from JDK 24+5
  • add @BasedOnJDKFile annotation for libsvm_container files imported from JDK
  • add mx gate --tags check_libcontainer_annotations gate job
  • add mx reimport-libcontainer-files --jdk-repo path/to/jdk/open

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 5, 2024
@zapster zapster self-assigned this Jul 5, 2024
@zapster zapster marked this pull request as draft July 5, 2024 07:51
@zapster
Copy link
Member

zapster commented Jul 5, 2024

@jerboaa while this follow-up PR to #8989 is still in progress, it should give you an idea how we gonna deal with keeping the libsvm_container up to date. Since that PR was lying around for some time now, I had the opportunity to re-import the code several times and it always was seamless and fast (<1h). With the @BasedOnJDKFile annotations we will never miss any changes to the relevant code. (And yes, we already noticed openjdk/jdk#18201 😉)

I hope that this will address most of the concerns you shared in #8989 (comment).

@zapster
Copy link
Member

zapster commented Jul 5, 2024

(Fun fact: I just noticed the behavior fixed by openjdk/jdk#18201 yesterday when testing this change and was a bit puzzled. So thanks for the fix. 🙂)

@jerboaa
Copy link
Collaborator

jerboaa commented Jul 5, 2024

Thanks for the heads-up.

@graalvmbot graalvmbot changed the title [WIP] [GR-54128] Re-import libsvm_container code and add change detection annotations [GR-54128] Re-import libsvm_container code and add change detection annotations Jul 9, 2024
@graalvmbot graalvmbot force-pushed the je/svm-reimport-cgroups-GR-54128 branch from a0477ad to 64d0a26 Compare July 9, 2024 12:33
@zapster zapster marked this pull request as ready for review July 9, 2024 12:47
@graalvmbot graalvmbot force-pushed the je/svm-reimport-cgroups-GR-54128 branch from 607061d to 232ff51 Compare July 9, 2024 16:26
@graalvmbot graalvmbot force-pushed the je/svm-reimport-cgroups-GR-54128 branch from 232ff51 to f912c53 Compare July 9, 2024 16:36
@graalvmbot graalvmbot closed this Jul 10, 2024
@graalvmbot graalvmbot merged commit 3750ce3 into master Jul 10, 2024
@graalvmbot graalvmbot deleted the je/svm-reimport-cgroups-GR-54128 branch July 10, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants