Skip to content

Conversation

graalvmbot
Copy link
Collaborator

Based on #9505.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 22, 2024
Copy link
Collaborator

@roberttoyonaga roberttoyonaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you for working on integrating this.

@roberttoyonaga
Copy link
Collaborator

Just a question, in the original PR, I iterate through all the ImageHeapInfo and sum up the used sizes. Is the reason for the chained ImageHeapInfo related to Layered Native Images? Is there a functional difference between how we get the Image Heap sizes in this PR and the original one?

@christianhaeubl
Copy link
Member

Is the reason for the chained ImageHeapInfo related to Layered Native Images

Yes.

Is there a functional difference between how we get the Image Heap sizes in this PR and the original one?

Yes, there is a bit of a difference. Your code computes the actually used number of image heap bytes (i.e., it only takes the parts into account that are really filled with objects). This number is always smaller than the actually committed memory (e.g., certain image heap parts are empty/unused and only exist for alignment reasons).

@graalvmbot graalvmbot closed this Sep 5, 2024
@graalvmbot graalvmbot deleted the chaeubl/GR-57310 branch September 5, 2024 20:41
@graalvmbot graalvmbot merged commit 75be5f8 into master Sep 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants