[GR-58651] Enforce correct values for Services.IS_[IN|BUILDING]_NATIVE_IMAGE in image-runtime. #9842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
changed the title
graalvmbot
changed the title
graalvmbot
changed the title
graalvmbot
force-pushed
the
paw/GR-58651
branch
from
0bfc7ad to
38b9d55
Compare
graalvmbot
force-pushed
the
paw/GR-58651
branch
from
38b9d55 to
0fca74b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the values of fields
Services.IS_IN_NATIVE_IMAGEorServices.IS_BUILDING_NATIVE_IMAGEof classjdk.vm.ci.services.Servicesof the JVMCI module that is used by the image builder is used in code that ends up in a native-image we need to make sure that these fields have the right values for this context. This PR makes sure of that.