Skip to content

Conversation

@antoniolago
Copy link
Contributor

@antoniolago antoniolago commented May 8, 2024

Before anything, this is my first code in GOlang, so any ideas to enhance this are appreciated.

Description of the change

This change adds oci-native-ingress.oraclecloud.com/extract-ca-from-tls-crt notation to ingresses which enables the parsing of the CA certificate from secret's tls.crt instead of getting it from ca.crt as explained in issue #60

Benefits

With this change cert-manager ACME users can generate certificates dynamically and integrate them with ocii-native-ingress-controller seamlessly

This will default to false.

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label May 8, 2024
@oracle-contributor-agreement
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels May 13, 2024
@nirpai
Copy link
Contributor

nirpai commented May 13, 2024

@antoniolago Thanks for the PR. This will be looked into.

@Inbaraj-S Inbaraj-S added the enhancement New feature or request label May 15, 2024
@piyush-tiwari
Copy link
Member

piyush-tiwari commented Jun 17, 2024

@antoniolago, thank you for the PR. We had a few changes here, so I opened up the PR #76 and added you as a co-author for the commit there. The OCA check is failing as your github no-reply email isn't recognised by OCA. Will you be willing to share the email you used in signing the OCA (which would be associated with your Oracle profile)? If not, I can instead ask for an override for the check here internally.

@antoniolago
Copy link
Contributor Author

antoniolago commented Jun 17, 2024

@antoniolago, thank you for the PR. We had a few changes here, so I opened up the PR #76 and added you as a co-author for the commit there. The OCA check is failing as your github no-reply email isn't recognised by OCA. Will you be willing to share the email you used in signing the OCA (which would be associated with your Oracle profile)? If not, I can instead ask for an override for the check here internally.

Hello, thanks for the response, of course, the email I used to sign the OCA is , let me know if anything else is needed.

@piyush-tiwari
Copy link
Member

piyush-tiwari commented Jun 17, 2024

@antoniolago, thank you, that maps to @antonioclago on GitHub, I hope you don't mind that?

@antoniolago
Copy link
Contributor Author

antoniolago commented Jun 17, 2024

Hey, sorry to bother, but the co author commit was linked to an old account, it's important to me that should be linked to this account, how can we make this happen? I changed the email address "" to this account

@piyush-tiwari
Copy link
Member

I think that did the trick, cd48e3b has your current account as the co-author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants