-
Notifications
You must be signed in to change notification settings - Fork 26
[Feature] Add extract-ca-from-tls-crt annotation (#60) #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: antoniolago <[email protected]>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
|
Thank you for signing the OCA. |
|
@antoniolago Thanks for the PR. This will be looked into. |
|
@antoniolago, thank you for the PR. We had a few changes here, so I opened up the PR #76 and added you as a co-author for the commit there. The OCA check is failing as your github no-reply email isn't recognised by OCA. Will you be willing to share the email you used in signing the OCA (which would be associated with your Oracle profile)? If not, I can instead ask for an override for the check here internally. |
Hello, thanks for the response, of course, the email I used to sign the OCA is , let me know if anything else is needed. |
|
@antoniolago, thank you, that maps to @antonioclago on GitHub, I hope you don't mind that? |
|
Hey, sorry to bother, but the co author commit was linked to an old account, it's important to me that should be linked to this account, how can we make this happen? I changed the email address "" to this account |
|
I think that did the trick, cd48e3b has your current account as the co-author. |
Before anything, this is my first code in GOlang, so any ideas to enhance this are appreciated.
Description of the change
This change adds oci-native-ingress.oraclecloud.com/extract-ca-from-tls-crt notation to ingresses which enables the parsing of the CA certificate from secret's tls.crt instead of getting it from ca.crt as explained in issue #60
Benefits
With this change cert-manager ACME users can generate certificates dynamically and integrate them with ocii-native-ingress-controller seamlessly
This will default to false.