Helidon v2.1.0 #36
Merged
Helidon v2.1.0 #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aberinnj
commented
Sep 6, 2024
aberinnj
commented
- Dependencies still using JDBC v19 and other packages that may be uneccessary, Updated
- No NPE guards for missing environment variables, Updated
- Environment variables not homogenous, and undocumented, Updated
- Add README for running instructions, Updated
- Improve code to be more flexible, Updated
oracle-contributor-agreement
bot
added
the
OCA Verified
|
@Kuassim Please review when possible and merge |
Kuassim
reviewed
Sep 6, 2024
mtdrworkshop/backend/src/main/java/com/oracle/database/AppDatasource.java
Show resolved
Hide resolved
Kuassim
reviewed
Sep 6, 2024
mtdrworkshop/backend/src/main/java/com/oracle/database/AppDatasource.java
Outdated
Show resolved
Hide resolved
Kuassim
requested changes
Sep 6, 2024
There was a problem hiding this comment.
- One Java code does not have Copyright (unless I am not seeing right).
- Make sure to use 2 tabs for indentation at each level (it looks like you are using 3 and sometimes more than 3.
- Use try-with-resource for code blocks with statements and resultSets; to make sure these are closed/freed.
|
Kuassim
approved these changes
Sep 6, 2024
|
@jeandelavarene Please review and merge when possible |
jeandelavarene
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.