Skip to content

Conversation

Yashpd
Copy link
Contributor

@Yashpd Yashpd commented Jul 4, 2019

No description provided.

Copy link
Collaborator

@Sedherthe Sedherthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yashpd Please check with the code. The counts are not accurate. For example, as given in the description, the counts of the first three words doesn't match with yours.

@Yashpd
Copy link
Contributor Author

Yashpd commented Jul 5, 2019

@Sedherthe I've update the Top90.txt and corrected the errors that had incurred. Pls check.

Copy link
Collaborator

@Sedherthe Sedherthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Yashpd ! There's still a mismatch in your counts. Are you sure you are using the same set of punctuation marks? I can see one "i in your words list, which should not be there. Please check.
Also, don't forget to use the stop words given.

@Yashpd
Copy link
Contributor Author

Yashpd commented Jul 11, 2019

Hi! I've updated the Top90.txt and corrected the errors. Actually, there was problem with the text processing function that I'd used.

@Sedherthe Sedherthe merged commit 7fb4872 into oss2019:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants