🌱 add cases for alerts in dangerous workflow pattern detection #4722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKorcz
requested review from
spencerschrock and
raghavkaul
and removed request for
a team
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4722 +/- ##
==========================================
+ Coverage 66.80% 68.31% +1.50%
==========================================
Files 230 249 +19
Lines 16602 18907 +2305
==========================================
+ Hits 11091 12916 +1825
- Misses 4808 5131 +323
- Partials 703 860 +157 🚀 New features to boost your workflow:
|
Signed-off-by: Adam Korczynski <[email protected]>
AdamKorcz
force-pushed
the
dw-alert-patterns
branch
from
3724c69 to
5de8b16
Compare
AdamKorcz
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
feature
What is the current behavior?
What is the new behavior (if this is a feature change)?
This PR adds cases that from my analysis are controllable by low-privileged users and can therefore be weaponized into command execution. These are fields of the
alertobject, see eg.secret_scanning_alert.alert(ref). The weaponizable fields are mainly user names or emails or comments in the context of alerts which can be controlled by lower-privileged users.Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
yes