Challenge repo init command #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
clarification: i do not care about code formatting feedback, such as the compiler warnings for the structs or the |
Contributor
detjensrobert
left a comment
detjensrobert
left a comment
There was a problem hiding this comment.
Structure comments:
- So far, I've tried to keep the bulk of the logic for comands in their own folders, and
run()orchestrates which thing to call based on the command line flags (i.e.build::run()calls build_image() and then push_images() if--pushwas given). I think the*_init()functions and the struct definitions should go in their own folder/file to follow this. Thoughts from the rest of the team?
Author
done |
Author
|
Since this PR is so out of date with the |
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
detjensrobert
force-pushed
the
af/init-command
branch
2 times, most recently
from
2510f36 to
bdfd2bd
Compare
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
We already have an existing struct used to parse the rcds.yaml config, use that to build the example/interactive config instead of creating an almost-identical struct. So far this is only done for the example values / non-interactive init. Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Having this be a string is more user friendly than a number, and this branch was originally set up to do that. Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
Blank and placeholder template files should be set explicitly by the user. Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
serde_yml turns out to be maintained weirdly (issues disabled, weird refactors) and is now archived anyway. _ng is what the community is now recommending. Signed-off-by: Robert Detjens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a premature PR on this so that I can get midway feedback and get most of my "TODO" questions answered this Sunday (not all of the TODOs are for y'all but most of them are, feel free to comment on any you want to give insight on). Please add your answers to the TODOs via comments in a review on this PR since I can't be there this Sunday