This repository was archived by the owner on Jul 27, 2022. It is now read-only.
修改targetPath为Laravel 9目录结构 && 代码格式调整 #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjfz
commented
Mar 2, 2022
| if (!is_dir($targetPath) && !mkdir($targetPath)) { | ||
| return $this->error('The lang path "resources/lang/" does not exist or not writable.'); | ||
| $this->error('The lang path "lang" does not exist or not writable.'); | ||
| return; |
wjfz
commented
Mar 2, 2022
| $process->run(function ($type, $buffer) { | ||
| if (Process::ERR === $type) { | ||
| return $this->error(trim($buffer)); | ||
| $this->error(trim($buffer)); |
Author
There was a problem hiding this comment.
'return' is unnecessary as the last statement in a function
wjfz
commented
Mar 2, 2022
| * @param array $paths | ||
| */ | ||
| public function __construct(Filesystem $files, $path, $paths = []) | ||
| public function __construct(Filesystem $files, string $path, array $paths = []) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.