Skip to content

Conversation

DeepDiver1975
Copy link
Member

No description provided.

@jnweiger jnweiger mentioned this pull request Sep 17, 2024
43 tasks
@jnweiger jnweiger mentioned this pull request Sep 18, 2024
17 tasks
@jnweiger
Copy link
Contributor

jnweiger commented Sep 20, 2024

Silly admin scenario:

  • admin believes, users should not see a toplevel /Notes folder, but have their notes inside e.g. an /apps/priv/NotesDir subfolder
    • update oc_preferences set configvalue = 'apps/priv/NotesDir' where userid='Alice' and appid='notes' and configkey='notesRoot';
  • Bob has an apps folder with some nice binaries, and shares that with Alice, before Alice uses the notes app for the first time.
  • Alice starts using the notes app.
    • The notesRoot gets reset to a toplevel folder 'Notes' -- or (2) or (3) etc as needed. OKish.

@jnweiger jnweiger self-requested a review September 20, 2024 14:05
@jnweiger
Copy link
Contributor

jnweiger commented Sep 20, 2024

@DeepDiver1975 Is this a scenario to consider:

Update from notes app 2.0.5

  • User bob receives shared Notes folder from user alice
  • User bob starts the notes app, happily adds notes (which is a security issue)
  • Admin updates to the notes app including fix: ensure that notes are not stored inside a shared folder #488
  • The new notes app changes notesRoot to a 'Notes (2)' folder. Which is now empty. OKish
  • User bob panics, as he believes all his notes are lost. BAD
  • User bob hopefully realizes that the shared Notes folder is still there, and sorts things out.

@DeepDiver1975
Copy link
Member Author

  • User bob hopefully realizes that the shared Notes folder is still there, and sorts things out.

Users will get this if they ever fall into this pit. Please note that this is a very unlikely scenario is real life.

@DeepDiver1975 DeepDiver1975 force-pushed the fix/dont-store-notes-in-shared-folder branch from b248957 to 518ae81 Compare September 23, 2024 12:41
@DeepDiver1975 DeepDiver1975 merged commit 7821ace into master Sep 23, 2024
1 check passed
@jnweiger
Copy link
Contributor

Thanks!

@DeepDiver1975 DeepDiver1975 deleted the fix/dont-store-notes-in-shared-folder branch October 17, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants