linter: eslint-plugin-react-hooks not working with underscored function

[skovhus]

What version of Oxlint are you using?

1.22.0

What command did you run?

No response

What does your .oxlintrc.json config file look like?

{
  "rules": {
    "react-hooks/rules-of-hooks": "warn"
  }
}

What happened?

False positive for eslint-plugin-react-hooks when prefixing component function with _

This is marked as invalid, but fairly comment to preview a mobx wrapped component with _

import { observer } from "mobx-react-lite";

export const CommentLikeActivityEntry = observer(function _CommentLikeActivityEntry({
  const reduceMotion = useReducedMotion() ?? false;
  return null;
});

As a workaround this works:

import { observer } from "mobx-react-lite";

export const CommentLikeActivityEntry = observer(function CommentLikeActivityEntry_({
  const reduceMotion = useReducedMotion() ?? false;
  return null;
});

React Hook "useReducedMotion" is called in function "_CommentLikeActivityEntry" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use".oxc[eslint-plugin-react-hooks(rules-of-hooks)](https://oxc.rs/docs/guide/usage/linter/rules/react/rules-of-hooks.html)

[camc314]

I tested this with eslint-plugin-react-hooks, and oxlint has the same behaviour as eslint.

What version of eslint-plugin-react-hooks were you using.

Interestingly, there is this PR from the react repo which changes how components are identifier from being non-upper case letters, to being uppercase letters.

See the example here: https://github.com/camc314/oxlint-repros/blob/89fa982f268acf8024cb6d6e607cf108077c0a3c/issue-lin-rules-of-hooks/README.md#L0-L1

[skovhus]

Embarrassingly, we were on "eslint-plugin-react-hooks": "4.6.2". Oh man, just another good argument for why these rules should be baked into the tool like oxlint.

Thanks for digging this up Cameron, and thanks for a great conference.

[camc314]

Great! glad to have it solved!

Thank you for presenting!