-
Couldn't load subscription status.
- Fork 60
[sled-agent] Add Sleds to DB #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- "Adding sleds once" supported; no liveness checking or re-insertion. - APIs to fetch/list sleds added. - Removed the 'collection' APIs in omicron-common; after using paginated DB support for sleds, these appear unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments, but otherwise LGTM! Thanks for doing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This feels like a big step towards making everything more "real".
re-insertion.
using paginated DB support for sleds, these appear unused.