Skip to content

Conversation

@smklein
Copy link
Collaborator

@smklein smklein commented Sep 13, 2021

  • "Adding sleds once" supported; no liveness checking or
    re-insertion.
  • APIs to fetch/list sleds added.
  • Removed the 'collection' APIs in omicron-common; after
    using paginated DB support for sleds, these appear unused.

- "Adding sleds once" supported; no liveness checking or
re-insertion.
- APIs to fetch/list sleds added.
- Removed the 'collection' APIs in omicron-common; after
using paginated DB support for sleds, these appear unused.
@smklein smklein requested a review from davepacheco September 13, 2021 16:54
@smklein smklein linked an issue Sep 13, 2021 that may be closed by this pull request
4 tasks
@smklein smklein requested a review from bnaecker September 20, 2021 12:11
Copy link
Collaborator

@bnaecker bnaecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, but otherwise LGTM! Thanks for doing this.

@smklein smklein added database Related to database access nexus Related to nexus Sled Agent Related to the Per-Sled Configuration and Management labels Sep 22, 2021
Copy link
Collaborator

@davepacheco davepacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This feels like a big step towards making everything more "real".

@smklein smklein merged commit 6f634f6 into main Oct 6, 2021
@smklein smklein deleted the sled-in-db branch October 6, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

database Related to database access nexus Related to nexus Sled Agent Related to the Per-Sled Configuration and Management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Nexus' representation of Sleds durable

5 participants