Implement /vpcs/:vpc/routers CRUD
#311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you haven't seen it, the discussion in https://github.com/oxidecomputer/rfd/issues/274 might also be useful. |
smklein
reviewed
Oct 15, 2021
zephraph
force-pushed
the
add-router-api
branch
from
2a3a102 to
64583eb
Compare
zephraph
changed the title
/vpcs/:vpc/routers/vpcs/:vpc/routers CRUD
zephraph
force-pushed
the
add-router-api
branch
from
64919a4 to
8ba10b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a bit of a work in progress. I'm building off of the context from RFD-21. Still learning my way around rust so there's a potential for some glaring things to be wrong at the moment, but I'll get it sorted.
With that said, there's still potential for this route name to change. In last Thursday's product huddle there was a conversation about naming.
It's worth also reading @rmustacc's feedback on oxidecomputer/console#476. Lastly @benjaminleonard's designsshow potential usage for this route.