update steno dep to handle undo actions failing #3211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
davepacheco
changed the title
davepacheco
changed the title
davepacheco
changed the title
bnaecker
reviewed
May 24, 2023
Collaborator
bnaecker
left a comment
bnaecker
left a comment
There was a problem hiding this comment.
I think this is a good path forward! It'll definitely be nice to have more insight into when undo actions fail, rather than a crash-loop :)
bnaecker
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on oxidecomputer/steno#138.
This updates Omicron for the small breaking change associated with having Steno not panic when undo actions fail. The breakage is basically that there's a new kind of error that can be produced by running a saga and we want to handle that specially (include that in the error message, log loudly, and report the saga as "stuck" over the debug API).