[1/n] [omicron-package] move config into a separate file #7285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
changed the title
smklein
approved these changes
Dec 20, 2024
sunshowers
deleted the
sunshowers/spr/omicron-package-move-config-into-a-separate-file
branch
sunshowers
added a commit
that referenced
this pull request
Dec 20, 2024
* If no target is specified, don't print a confusing `the name '{name}'
is reserved` message.
* For `target delete`, if removing the file failed, print the
corresponding error message.
Depends on #7285.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to add to this config, and I didn't want to cram
omicron-package.rswith even more information.This is pure code movement with no functional changes.