fix!: replace v2 extra with compat-v2 #1280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Rename the
v2extra/feature tocompat-v2. As a result, to install Pact Python with v2 compatibility, you will need to now use:pip install 'pact-python[compat-v2]`🚨 Breaking Changes
Installing Pact Python with v2 compatibility requires
pip install 'pact-python[compat-v2]', and the oldpip install 'pact-python[v2]'is no longer supported.🔥 Motivation
The
v2group of optional dependencies unfortunately results in an issue when Pact Python is installed usingpip, aspiptries to parse the group name as if it were a version. To avoid this, the group has been renamed tocompat-v2which should bypass the version parsing.While this is a bug in
pip, pip comes pre-bundled in many situations and is rarely at the latest version; so it is impractical to wait for the upstream issue to be resolved.🔨 Test Plan
🔗 Related issues/PRs
Fixes: #1275
Ref: pypa/packaging#938