Skip to content

Conversation

@chris-b1
Copy link
Contributor

@jreback jreback added the IO CSV read_csv, to_csv label Mar 10, 2019
@jorisvandenbossche jorisvandenbossche added this to the 0.24.2 milestone Mar 10, 2019
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #25625 into master will decrease coverage by 49.54%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #25625       +/-   ##
===========================================
- Coverage   91.26%   41.71%   -49.55%     
===========================================
  Files         173      173               
  Lines       52968    52968               
===========================================
- Hits        48339    22096    -26243     
- Misses       4629    30872    +26243
Flag Coverage Δ
#multiple ?
#single 41.71% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/generic.py 37.9% <ø> (-55.76%) ⬇️
pandas/io/common.py 43.79% <0%> (-29.07%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/core/categorical.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.36%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e28ae70...0d73266. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #25625 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25625   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files         173      173           
  Lines       52961    52961           
=======================================
  Hits        48350    48350           
  Misses       4611     4611
Flag Coverage Δ
#multiple 89.86% <100%> (ø) ⬆️
#single 41.73% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/common.py 72.86% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4fa3c9...998979c. Read the comment docs.

@jorisvandenbossche
Copy link
Member

Failure is unrelated, see #25652

@jreback
Copy link
Contributor

jreback commented Mar 11, 2019

lgtm. ping on green.

@jorisvandenbossche jorisvandenbossche merged commit 43b949d into pandas-dev:master Mar 11, 2019
@jorisvandenbossche
Copy link
Member

Thanks @chris-b1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO CSV read_csv, to_csv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataFrame to_csv line_terminator inconsistency when using compression

3 participants