Skip to content

Conversation

@ivanovmg
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Use new kwarg default_axes in _check_plot_works (#37274), which allows one to eliminate catching warnings related to multiple subplots created.
There warnings are not related to the plotting function, but rather were caused by the _check_plot_works itself.

Copy link
Contributor

@charlesdong1991 charlesdong1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@charlesdong1991 charlesdong1991 added Clean Testing pandas testing functions or related to the test suite Visualization plotting labels Nov 10, 2020
@charlesdong1991 charlesdong1991 added this to the 1.2 milestone Nov 10, 2020
@WillAyd WillAyd merged commit daf999f into pandas-dev:master Nov 10, 2020
@WillAyd
Copy link
Member

WillAyd commented Nov 10, 2020

Thanks @ivanovmg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean Testing pandas testing functions or related to the test suite Visualization plotting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants