[ArrayManager] Indexing - implement iset #39734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Indexing
jreback
requested changes
Feb 11, 2021
| """ | ||
| Set new item in-place. Does not consolidate. Adds new Block if not | ||
| contained in the current set of items | ||
| Set new column in-place (replaces (an) existing column(s)). |
Member
There was a problem hiding this comment.
I think this is specifically not-inplace.
This will behave differently from the BlockManager implementation. We should test and/or explicitly comment on that.
Member
Author
There was a problem hiding this comment.
I mean that it changes the ArrayManager in place (it doesn't return a new ArrayManager). I think that's the same as BlockManager?
For the rest, it replaces the array for a column, so yet it explicitly not-inplace from the array point of view, as it just gets swapped.
Will try to improve the comment.
jreback
approved these changes
Feb 15, 2021
Contributor
|
lgtm. @jbrockmendel |
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #39146, follow-up on #39722