Skip to content

Conversation

@gsheni
Copy link
Contributor

@gsheni gsheni commented May 15, 2022

@pep8speaks
Copy link

pep8speaks commented May 15, 2022

Hello @gsheni! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-05-15 03:47:56 UTC

@gsheni gsheni changed the title ENH Add float[pyarrow] dtype WIP: ENH Add float[pyarrow] dtype May 15, 2022
@gsheni gsheni mentioned this pull request May 15, 2022
3 tasks
@gsheni
Copy link
Contributor Author

gsheni commented May 15, 2022

@github-actions pre-commit

@mroeschke
Copy link
Member

mroeschke commented May 15, 2022

Thanks for starting this. Just a heads up, I think we won't be expanding support for pyarrow dtypes quite like this (the subclass approach).

If you'd like to help of this front, investigating how StringArrowArray and StringDtype for pyarrow can be further merged into ArrowExtensionArray and ArrowDtype respectively would be helpful instead.

@gsheni gsheni closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants