add test to check type of df column after loc() #47264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @mroeschke, I'd like to start writing tests for a lot of the existing GH issues. I am learning as I go, so I am not sure if something like this is sufficient and/or in the right place. Any critical feedback would be greatly appreciated so I can start writing better and more complex tests. Thanks! |
Member
|
Awesome! Definitely check out https://pandas.pydata.org/docs/dev/development/contributing_codebase.html#using-pytest for all the details of how tests ideally should be structured and what should be included |
mroeschke
reviewed
Jun 7, 2022
mroeschke
reviewed
Jun 7, 2022
mroeschke
reviewed
Jun 7, 2022
|
Hello @jackgoldsmith4! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-06-12 18:18:15 UTC |
mroeschke
approved these changes
Jun 13, 2022
mroeschke
added
the
Testing
Member
|
Thanks @jackgoldsmith4 |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* add test * double quotes * fixes * remove pd * fix index type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.