Skip to content

REF: restore _concat_managers_axis0 #50401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2022
Merged

REF: restore _concat_managers_axis0 #50401

merged 2 commits into from
Dec 27, 2022

Conversation

@jbrockmendel
Copy link
Member

It was removed in #47372 but removing it was not the point of that PR, just a side-effect.

mroeschke
mroeschke reviewed Dec 27, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Motivation for adding this back is that it's more performant?

@mroeschke mroeschke added the Refactor Internal refactoring of code label Dec 27, 2022
@jbrockmendel
Copy link
Member Author

Motivation for adding this back is that it's more performant?

Mostly simpler. IIRC it might be a little more performant but very slight.

@mroeschke mroeschke added this to the 2.0 milestone Dec 27, 2022
@mroeschke mroeschke merged commit 483a4f5 into pandas-dev:main Dec 27, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-concat-ax0 branch December 27, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees

No one assigned

Labels

Refactor Internal refactoring of code

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @mroeschke