Skip to content

TST: add test case of ngroup with NaN value #54966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 6, 2023
Merged

TST: add test case of ngroup with NaN value #54966

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9ef05b1
add test case of ngroup with nan value
josemayer Sep 2, 2023
18b6c5a
Merge remote-tracking branch 'upstream/main' into ngroup-test-with-nan
josemayer Sep 2, 2023
ae975f2
fix linter issues
josemayer Sep 2, 2023
38a6454
use Categorical object instead of pd.Categorical
josemayer Sep 2, 2023
3a7dc58
use native assert function
josemayer Sep 5, 2023
669b3e5
test full result of ngroup method
josemayer Sep 6, 2023
c7c167f
Merge remote-tracking branch 'upstream/main' into ngroup-test-with-nan
josemayer Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pandas/tests/groupby/test_groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3189,6 +3189,14 @@ def test_depr_get_group_len_1_list_likes(test_series, kwarg, value, name, warn):
tm.assert_equal(result, expected)


def test_groupby_ngroup_with_nan():
# GH#50100
df = DataFrame({"a": Categorical([np.nan]), "b": [1]})
result = df.groupby(["a", "b"], dropna=False, observed=False).ngroup()
expected = Series([0])
tm.assert_series_equal(result, expected)


def test_get_group_axis_1():
# GH#54858
df = DataFrame(
Expand Down