-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
C-debtA clean up/refactor of existing codeA clean up/refactor of existing codeC-enhancementNew feature or requestNew feature or requestD-good-first-issueNice and easy! A great choice to get startedNice and easy! A great choice to get started
Description
Describe the feature
These matches can all be reduced to a single .versioned_hashes call with latest alloy patch:
reth/crates/transaction-pool/src/blobstore/disk.rs
Lines 309 to 320 in 608ed59
| match data { | |
| BlobTransactionSidecarVariant::Eip4844(data) => { | |
| data.versioned_hashes().for_each(|hash| { | |
| map.insert(hash, *tx); | |
| }); | |
| } | |
| BlobTransactionSidecarVariant::Eip7594(data) => { | |
| data.versioned_hashes().for_each(|hash| { | |
| map.insert(hash, *tx); | |
| }); | |
| } | |
| } |
TODO
- bump allo deps:
Lines 473 to 499 in 608ed59
alloy-consensus = { version = "1.0.5", default-features = false } alloy-contract = { version = "1.0.5", default-features = false } alloy-eips = { version = "1.0.5", default-features = false } alloy-genesis = { version = "1.0.5", default-features = false } alloy-json-rpc = { version = "1.0.5", default-features = false } alloy-network = { version = "1.0.5", default-features = false } alloy-network-primitives = { version = "1.0.5", default-features = false } alloy-provider = { version = "1.0.5", features = ["reqwest"], default-features = false } alloy-pubsub = { version = "1.0.5", default-features = false } alloy-rpc-client = { version = "1.0.5", default-features = false } alloy-rpc-types = { version = "1.0.5", features = ["eth"], default-features = false } alloy-rpc-types-admin = { version = "1.0.5", default-features = false } alloy-rpc-types-anvil = { version = "1.0.5", default-features = false } alloy-rpc-types-beacon = { version = "1.0.5", default-features = false } alloy-rpc-types-debug = { version = "1.0.5", default-features = false } alloy-rpc-types-engine = { version = "1.0.5", default-features = false } alloy-rpc-types-eth = { version = "1.0.5", default-features = false } alloy-rpc-types-mev = { version = "1.0.5", default-features = false } alloy-rpc-types-trace = { version = "1.0.5", default-features = false } alloy-rpc-types-txpool = { version = "1.0.5", default-features = false } alloy-serde = { version = "1.0.5", default-features = false } alloy-signer = { version = "1.0.5", default-features = false } alloy-signer-local = { version = "1.0.5", default-features = false } alloy-transport = { version = "1.0.5" } alloy-transport-http = { version = "1.0.5", features = ["reqwest-rustls-tls"], default-features = false } alloy-transport-ipc = { version = "1.0.5", default-features = false } alloy-transport-ws = { version = "1.0.5", default-features = false } - update all match statements for this
Additional context
No response
Metadata
Metadata
Assignees
Labels
C-debtA clean up/refactor of existing codeA clean up/refactor of existing codeC-enhancementNew feature or requestNew feature or requestD-good-first-issueNice and easy! A great choice to get startedNice and easy! A great choice to get started
Type
Projects
Status
Done