-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
A-op-rethRelated to Optimism and op-rethRelated to Optimism and op-rethA-sdkRelated to reth's use as a libraryRelated to reth's use as a libraryC-enhancementNew feature or requestNew feature or request
Description
Describe the feature
for #16451 we should do the same for OpEthapi as we did for ethapi:
reth/crates/rpc/rpc/src/eth/core.rs
Lines 63 to 68 in c36b543
| pub struct EthApi<Provider: BlockReader, Pool, Network, EvmConfig> { | |
| /// All nested fields bundled together. | |
| #[deref] | |
| pub(super) inner: Arc<EthApiInner<Provider, Pool, Network, EvmConfig>>, | |
| /// Transaction RPC response builder. | |
| pub tx_resp_builder: EthTxBuilder, |
reth/crates/rpc/rpc/src/eth/core.rs
Lines 163 to 165 in c36b543
| fn tx_resp_builder(&self) -> &Self::TransactionCompat { | |
| &self.tx_resp_builder | |
| } |
instead of for OpEthapi
reth/crates/optimism/rpc/src/eth/mod.rs
Lines 112 to 114 in c36b543
| fn tx_resp_builder(&self) -> &Self::TransactionCompat { | |
| self | |
| } |
| impl<N> TransactionCompat<OpTransactionSigned> for OpEthApi<N> |
this way we can decouple the rpc response and the txtype:
| tx: Recovered<OpTransactionSigned>, |
and make this a configurable on OpEthapi itself
Additional context
No response
Metadata
Metadata
Assignees
Labels
A-op-rethRelated to Optimism and op-rethRelated to Optimism and op-rethA-sdkRelated to reth's use as a libraryRelated to reth's use as a libraryC-enhancementNew feature or requestNew feature or request
Type
Projects
Status
Completed