Skip to content

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented May 9, 2025

smol #15312 followup

only acquire the mutex once

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker May 9, 2025
@mattsse mattsse added the C-perf A change motivated by improving speed, memory usage or disk footprint label May 9, 2025
@mattsse mattsse enabled auto-merge May 9, 2025 12:36
@mattsse mattsse disabled auto-merge May 12, 2025 11:11
@mattsse mattsse merged commit a12a296 into main May 12, 2025
45 checks passed
@mattsse mattsse deleted the matt/batch-create branch May 12, 2025 11:11
@github-project-automation github-project-automation bot moved this from Backlog to Done in Reth Tracker May 12, 2025
greged93 added a commit to scroll-tech/reth that referenced this pull request May 28, 2025
* refactor(mempool): Optimize validation task lock duration by moving async fut creation outside lock (paradigmxyz#16159)

Co-authored-by: Matthias Seitz <[email protected]>

* perf: use estimated_compressed_size for DA limiter (paradigmxyz#16153)

Co-authored-by: Matthias Seitz <[email protected]>

* chore: remove redundant NodeTypes bounds (paradigmxyz#16160)

* chore: bump alloy 0.15.11 (paradigmxyz#16163)

* perf: dont alloc on delegation limit check (paradigmxyz#16135)

* perf: batch create sender ids (paradigmxyz#16134)

* refactor: make gas_limit optional (paradigmxyz#16161)

Co-authored-by: Matthias Seitz <[email protected]>

* feat(engine): set keep alive for Tokio threads (paradigmxyz#16162)

* perf(trie): optimize TrieNodeIter by skipping redundant seek (paradigmxyz#15841)

Signed-off-by: 7suyash7 <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>

* test: handle reorg event properly by pool maintaining (paradigmxyz#16155)

* chore: replace filteredParams with Filterset (paradigmxyz#16077)

Co-authored-by: James <[email protected]>

* fix: prevent memory bloat during extended finalization periods (paradigmxyz#16157)

* chore: update hive expected failures (paradigmxyz#16167)

* feat(trie): instrument `TrieNodeIter::try_next` (paradigmxyz#16127)

* deps: bump libmdbx to 0.13.6 (paradigmxyz#15412)

* chore: extract TreeState to separate submodule (paradigmxyz#16172)

* fix(tree): add colon to sparse trie task logs (paradigmxyz#16175)

* feat: add fns to map engine builders (paradigmxyz#16171)

* fix: correctly set txtype if `blobVersionedHashes` is present (paradigmxyz#16182)

* chore(txpool): activate prague by default (paradigmxyz#16183)

* refactor: add alloy_consensus::SignerRecoverable to SingedTransaction supertrait (paradigmxyz#16174)

* feat(txpool): track osaka activation (paradigmxyz#16184)

* feat: Adding cronjob for superchain (paradigmxyz#16141)

* refactor(optimism_txpool): Move interop revalidation logic to SupervisorClient stream (paradigmxyz#16148)

Signed-off-by: 7suyash7 <[email protected]>

* chore(txpool): update comments about prague activation (paradigmxyz#16185)

* chore: add error when unwind failed on launch (paradigmxyz#16188)

* chore: interop maintain touchups (paradigmxyz#16187)

* fix: use different cache instance per precompile (paradigmxyz#16191)

* docs: fix typos in observability.md (paradigmxyz#16186)

* chore: bump log GetPayload events to debug level (paradigmxyz#16196)

* feat(trie): add `clear` method to PrefixSetMut, RevealedSparseTrie, SparseTrieUpdates (paradigmxyz#16179)

Co-authored-by: Alexey Shekhirin <[email protected]>

* feat: add PrecompileCacheMap::cache_for_address and test (paradigmxyz#16197)

* feat: add func gas_limit_for PayloadConfig (paradigmxyz#16210)

Co-authored-by: Matthias Seitz <[email protected]>

* chore(deps): migrate to jsonrpsee 0.25 (paradigmxyz#15956)

Co-authored-by: Matthias Seitz <[email protected]>

* feat: impl of bad_blocks handler (paradigmxyz#16209)

Signed-off-by: Aliaksei Misiukevich <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>

* fix: handle ForkChoiceUpdate errors with proper rpc error mapping (paradigmxyz#16215)

* feat: Integrate Osaka in blob_max_and_target_count_by_hardfork (paradigmxyz#16219)

* docs: fix JWT token link (paradigmxyz#16221)

* chore: Replacing filter id with subscription (paradigmxyz#16224)

Co-authored-by: Matthias Seitz <[email protected]>

* docs: clarify unit of txfeecap (paradigmxyz#16225)

* feat: simplify choosing txtype for tx request using .has methods (paradigmxyz#16227)

* feat: add check for osaka activation (paradigmxyz#16223)

* fix(trie): do not panic when logging the current hash of `TrieWalker` (paradigmxyz#16222)

* test(e2e): add CheckPayloadAccepted action (paradigmxyz#16220)

Co-authored-by: Federico Gimenez <[email protected]>

* chore: Replace `try_clone_into_recovered` with `try_into_recovered` to avoid unnecessary clone (paradigmxyz#16230)

* feat: Introduce with_signer_ref helper (paradigmxyz#16235)

* chore: de duplicate mainnet deposit contract (paradigmxyz#16074)

* feat(engine): add conversions for `ExecutionPayloadEnvelopeV5` (paradigmxyz#16218)

* refactor: relax `OpAddOns`  (paradigmxyz#16180)

* docs: clarify note on &mut self usage (paradigmxyz#16237)

* perf: replace collect with count (paradigmxyz#16246)

* feat: add from intoiter impls (paradigmxyz#16252)

* chore: rm jsonrpsee patch (paradigmxyz#16251)

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* chore(lint): Bumps dep `tempfile` (paradigmxyz#16253)

* fix: receipts logs arg parsing (paradigmxyz#16240)

* refactor: Migrate InvalidInboxEntry to op-alloy (paradigmxyz#16260)

* chore: rename extendedtx to just extended (paradigmxyz#16265)

* feat(engine): respond unsupported for payload v5 pre-osaka (paradigmxyz#16268)

* feat(engine): add `engine_getPayloadV5` skeleton (paradigmxyz#16270)

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* docs: Fix typos in `static-file` crate README (paradigmxyz#16266)

* feat(txpool): add methods for retrieving `BlobsAndProofsV2` (paradigmxyz#16271)

* feat(engine): add osaka engine methods to capabilities (paradigmxyz#16272)

* Rkrasiuk/implement get payload v5 (paradigmxyz#16274)

* chore: bump alloy 1.0.3 (paradigmxyz#16277)

* docs: add note about superchain registry (paradigmxyz#16275)

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* chore: bump default gas limit for holesky (paradigmxyz#16278)

* feat(engine): implement `engine_getBlobsV2` (paradigmxyz#16279)

* chore: bump version 1.4.0 (paradigmxyz#16261)

* chore: change TxCustom to TxPayment (paradigmxyz#16281)

* chore: upstream tx_type derive to alloy::TransactionRequest (paradigmxyz#16284)

* chore: Construct a SubscriptionMessage with the sink's properties (paradigmxyz#16285)

* ci: fix Windows build in `release.yml` (paradigmxyz#16280)

* chore: release 1.4.1 (paradigmxyz#16286)

* test: stale txs could be evicted when maintaining txpool (paradigmxyz#16269)

* chore: bump inspectors 0.22.1 (paradigmxyz#16291)

* ci: deduplicate changelog in release notes (paradigmxyz#16294)

* refactor(rpc-builder): Use Box<dyn TaskSpawner> for RPC task handling (paradigmxyz#16297)

Signed-off-by: 7suyash7 <[email protected]>

* ci: separate workflow for reproducible release (paradigmxyz#16299)

* refactor(trie): pass rlp_buf as a mutable argument to rlp_node (paradigmxyz#16243)

Signed-off-by: 7suyash7 <[email protected]>

* ci: release dry run (paradigmxyz#16287)

* feat: added TransactionValidator::validate_transactions_with_origin (paradigmxyz#16238)

Co-authored-by: Matthias Seitz <[email protected]>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* ci: use `GITHUB_REF_NAME` env var in release.yml (paradigmxyz#16302)

* refactor: Remove `to_subscription_message` and update calls (paradigmxyz#16305)

* ci: bump base image for reproducible builds (paradigmxyz#16307)

* ci: add OP Reth binaries to release notes (paradigmxyz#16298)

* feat: introduce PoolTransaction::into_consensus_with2718 (paradigmxyz#16303)

* chore: bump inspectors 0.22.2 (paradigmxyz#16311)

* chore: Mark into_recovered_unchecked as deprecated (paradigmxyz#16283)

* refactor(mempool): Refactor transaction validation to use batch interface (paradigmxyz#16189)

Co-authored-by: Matthias Seitz <[email protected]>

* chore: add 7702 to announced (paradigmxyz#16312)

* chore: rm jsonrpsee features (paradigmxyz#16314)

* chore: make clippy happy (paradigmxyz#16316)

* chore: flatten deps (paradigmxyz#16315)

* chore(deps): weekly `cargo update` (paradigmxyz#16323)

Co-authored-by: github-merge-queue <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>

* chore: fix make-pr lint-codespell errors (paradigmxyz#16324)

Co-authored-by: Matthias Seitz <[email protected]>

* feat: implement IsTyped2781 for reth types (paradigmxyz#16325)

Co-authored-by: Matthias Seitz <[email protected]>

* docs: add some docs about TaskExecutor (paradigmxyz#16327)

* chore: Replace reth-provider with reth-storage-api in reth-rpc-api (paradigmxyz#16322)

* feat: include SpecId in PrecompileCache keys (paradigmxyz#16241)

* feat: introduce Receipt69 variant (paradigmxyz#15827)

Co-authored-by: Matthias Seitz <[email protected]>

* chore(hive): disable eth suite of devp2p sim (paradigmxyz#16341)

* feat(perp): optimize OpTxpool 2718 bytes encoding (paradigmxyz#16336)

* chore: bump alloy 1.0.4 (paradigmxyz#16345)

* feat(primitive-traits): relax mem size implementations for 4844 txs with sidecars (paradigmxyz#16349)

* chore: bump inspectors (paradigmxyz#16342)

* feat(ethereum-primitives): `PooledTransactionVariant` alias (paradigmxyz#16351)

* chore: add `clippy-op-dev` make script (paradigmxyz#16352)

* chore: `RecoveredBlock` -> `Block` (paradigmxyz#16321)

Co-authored-by: Roman Krasiuk <[email protected]>

* chore: bump alloy (paradigmxyz#16355)

* chore: bump version 1.4.2 (paradigmxyz#16357)

* ci: do not dry run by default in `release.yml` (paradigmxyz#16358)

* chore: Add configuration option to enable/disable HTTP response compression (paradigmxyz#16348)

Co-authored-by: Matthias Seitz <[email protected]>

* ci: check `dry_run` against `true` in release workflow (paradigmxyz#16360)

* chore: bump version 1.4.3 (paradigmxyz#16359)

* ci: do not trigger release workflow on `dry_run*` branches (paradigmxyz#16361)

* feat: add BlockRangeUpdate message for eth/69 (paradigmxyz#16346)

Co-authored-by: Matthias Seitz <[email protected]>

* feat(stages): reduce index history progress logging frequency (paradigmxyz#16290)

Co-authored-by: Alexey Shekhirin <[email protected]>

* chore: re-export node-builder as builder (paradigmxyz#16363)

* feat(txpool): use `BlobTransactionSidecarVariant` (paradigmxyz#16356)

* feat: Implement conversion from built-in transaction envelopes into `Extended` (paradigmxyz#16366)

* refactor(examples): Replace redundant type definitions with a `CustomTransaction` alias in the `custom_node` example (paradigmxyz#16367)

* feat(txpool): properly validate sidecar according to the active fork (paradigmxyz#16370)

* feat(txpool): activate osaka in tx validator (paradigmxyz#16371)

* refactor(examples): Split `evm` module into submodules in the `custom_node` example (paradigmxyz#16380)

* feat(examples): Add `CustomTxEnv` for EVM that supports conversions from the extended transaction envelope in the `custom_node` example (paradigmxyz#16381)

* feat(node): bump Hoodi gas limit to 60M (paradigmxyz#16379)

* feat(trie): decode proofs in multiproof task (paradigmxyz#16098)

Co-authored-by: Alexey Shekhirin <[email protected]>

* chore(deps): bump alloy-evm (paradigmxyz#16385)

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* chore: Move subscription_task_spawner into EthPubSubInner (paradigmxyz#16383)

* feat: relax OpNetworkBuilder type constraints (paradigmxyz#16387)

* fix(ipc): Improve server code correctness, logging, and doc comments (paradigmxyz#16372)

* chore: fixed broken link (paradigmxyz#16365)

* chore: Refactoring manual clone for opPoolBuilder (paradigmxyz#16392)

* fix: `InvalidTimestamp` display (paradigmxyz#16395)

Signed-off-by: Gregory Edison <[email protected]>

* feat(examples): Add `CustomEvm` for the execution of `CustomTransaction` in the `custom_node` example (paradigmxyz#16394)

* chore(book): Bump `alloy-hardforks` and `alloy-op-harfroks` (paradigmxyz#16300)

* feat: Genericise `stateless_validation` API so that it is not fixed to `Eth` types (paradigmxyz#16328)

Co-authored-by: Matthias Seitz <[email protected]>

* feat: relax OpEthApi type constraints (paradigmxyz#16398)

* fix: forward sequencer error (paradigmxyz#16401)

* feat: configure tracing layers (paradigmxyz#16126)

Co-authored-by: Matthias Seitz <[email protected]>

* chore: eth69 status message support (paradigmxyz#16099)

Co-authored-by: Matthias Seitz <[email protected]>

* feat(examples): Implement `EvmFactory` for `CustomEvm` in `custom_node` example (paradigmxyz#16404)

* feat: relax OpEthApiBuilder type constraints (paradigmxyz#16410)

* fix(RPC): Ensure `eth_getTransactionCount` returns correct nonce for 'pending' tag (paradigmxyz#16407)

* feat(tasks): enable graceful shutdown request via TaskExecutor (paradigmxyz#16386)

Signed-off-by: 7suyash7 <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>

* chore: Add `ClientInput` struct to `reth-stateless` (paradigmxyz#16320)

* feat: fix tasks metrics (paradigmxyz#16406)

* fix: grammar in multiple files (paradigmxyz#16403)

* refactor: use `impl IntoIterator` for transaction batches and streamline validation calls (paradigmxyz#16408)

* chore: Implementing get_by_versioned_hashes_v2 for InMemoryBlobStre a… (paradigmxyz#16390)

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Matthias Seitz <[email protected]>

* feat(examples): Make `CustomEvmTransaction` local and implement `FromRecoveredTx` and `FromTxWithEncoded` in `custom_node` example (paradigmxyz#16415)

* refactor(examples): Use `OpEvm` from `op-alloy-evm` instead of `op-revm` for `CustomEvm` in `custom_node` example (paradigmxyz#16417)

* fix: rewrite estimate loop condition (paradigmxyz#16413)

* ci: fix system icons width in release.yml (paradigmxyz#16420)

* feat(net): Add update_block_range to NetworkSyncUpdater (paradigmxyz#16422)

Signed-off-by: 7suyash7 <[email protected]>

* feat: relax OpExecutorBuilder type constraints (paradigmxyz#16423)

* feat: make max EthMessageID dependent on the EthVersion (paradigmxyz#16405)

Co-authored-by: Matthias Seitz <[email protected]>

* ci: run op-kurtosis every 6hrs (paradigmxyz#16432)

* ci: run kurtosis every 6h (paradigmxyz#16433)

* perf: spawn range query on blocking (paradigmxyz#16434)

* chore: bump revm and op-alloy (paradigmxyz#16429)

Co-authored-by: Ishika Choudhury <[email protected]>

* feat: add get_recovered_transaction helper (paradigmxyz#16436)

* feat(examples): Implement `BlockAssembler` and `BlockExecutor` for custom blocks in `custom_node` example (paradigmxyz#16435)

* feat(optimism): Remove all bounds on `BlockAssemblerInput` for header (paradigmxyz#16442)

* feat!: Add `StatelessTrie` abstraction (paradigmxyz#16419)

* refactor(examples): Rename `CustomTxEnv` => `PaymentTxEnv` and `CustomEvmTransaction` => `CustomTxEnv` (paradigmxyz#16443)

* chore: simplify deposit check (paradigmxyz#16452)

* chore: rm OpPrimitives bound (paradigmxyz#16450)

* chore: make clippy happy (paradigmxyz#16455)

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* docs: added parent_beacon_block_root requirement and corrected build-block (paradigmxyz#16453)

* chore: add clone impl for engine api types (paradigmxyz#16454)

* refactor: remove reth dependencies and instead use reth_ethereum (paradigmxyz#16416)

Co-authored-by: Matthias Seitz <[email protected]>

* chore: rm outdated unreachable patterns (paradigmxyz#16457)

* chore: bump alloy 1.0.7 (paradigmxyz#16456)

* feat: add HistoricalRpcClient for forwarding legacy RPC requests (paradigmxyz#16447)

Co-authored-by: Matthias Seitz <[email protected]>

* ci: remove concurrency from bench (paradigmxyz#16458)

* chore(deps): weekly `cargo update` (paradigmxyz#16460)

Co-authored-by: github-merge-queue <[email protected]>

* fix(db): correct ClientVersion serialization size tracking (paradigmxyz#16427)

* feat: add receipts_by_block_range to ReceiptsProvider (paradigmxyz#16449)

* refactor: unify versioned_hashes for BlobTransactionSidecarVarient (paradigmxyz#16461)

* chore: run hive every 6h (paradigmxyz#16472)

* feat: add exex feature to op-reth (paradigmxyz#16459)

* fix: check encoded size (paradigmxyz#16473)

* chore: add manual clone impl (paradigmxyz#16475)

* fix: propagate `--sequencer-headers` to `SequencerClient` (paradigmxyz#16474)

* chore: relax executiondata bound (paradigmxyz#16478)

* revert: "fix: check encoded size" (paradigmxyz#16488)

* feat(examples): Add `CustomExecutorBuilder` and implement `ExecutorBuilder` for it in `custom_node` example (paradigmxyz#16444)

* chore: bump op-alloy to  0.17.2 (paradigmxyz#16492)

* feat(optimism): Replace `OpTransactionSigned` bound on the `Block` associated to `OpEngineValidator` with a generic (paradigmxyz#16486)

* feat: api changes

Signed-off-by: Gregory Edison <[email protected]>

* fix: lints

Signed-off-by: Gregory Edison <[email protected]>

* fix: lints

Signed-off-by: Gregory Edison <[email protected]>

* fix: lints

Signed-off-by: Gregory Edison <[email protected]>

* fix: book lint

* fix: book lints

* fix: point revm-scroll to main

Signed-off-by: Gregory Edison <[email protected]>

---------

Signed-off-by: 7suyash7 <[email protected]>
Signed-off-by: Aliaksei Misiukevich <[email protected]>
Signed-off-by: Gregory Edison <[email protected]>
Co-authored-by: Acat <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>
Co-authored-by: Z <[email protected]>
Co-authored-by: Federico Gimenez <[email protected]>
Co-authored-by: Veer Chaurasia <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>
Co-authored-by: Suyash Nayan <[email protected]>
Co-authored-by: int88 <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: Dan Cline <[email protected]>
Co-authored-by: Arsenii Kulikov <[email protected]>
Co-authored-by: Roman Krasiuk <[email protected]>
Co-authored-by: fantasyup <[email protected]>
Co-authored-by: Ayush Dubey <[email protected]>
Co-authored-by: Mark Diloff <[email protected]>
Co-authored-by: Aliaksei Misiukevich <[email protected]>
Co-authored-by: Merkel Tranjes <[email protected]>
Co-authored-by: Yeongjong Pyo <[email protected]>
Co-authored-by: cakevm <[email protected]>
Co-authored-by: Louis Brown <[email protected]>
Co-authored-by: Léa Narzis <[email protected]>
Co-authored-by: 0xriazaka.eth <[email protected]>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Emilia Hane <[email protected]>
Co-authored-by: James Niken <[email protected]>
Co-authored-by: Victor Farazdagi <[email protected]>
Co-authored-by: Developer Uche <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-merge-queue <[email protected]>
Co-authored-by: Femi Bankole <[email protected]>
Co-authored-by: Shourya Chaudhry <[email protected]>
Co-authored-by: stevencartavia <[email protected]>
Co-authored-by: kevaundray <[email protected]>
Co-authored-by: AlexYue <[email protected]>
Co-authored-by: Max Bytefield <[email protected]>
Co-authored-by: Roman Hodulák <[email protected]>
Co-authored-by: Torprius <[email protected]>
Co-authored-by: Oleg <[email protected]>
Co-authored-by: Denis Kolodin <[email protected]>
Co-authored-by: Shane K Moore <[email protected]>
Co-authored-by: Solar Mithril <[email protected]>
Co-authored-by: crStiv <[email protected]>
Co-authored-by: Ishika Choudhury <[email protected]>
Co-authored-by: DaniPopes <[email protected]>
Co-authored-by: Bilog WEB3 <[email protected]>
Co-authored-by: Soubhik Singha Mahapatra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-perf A change motivated by improving speed, memory usage or disk footprint

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant