Skip to content

fix(RPC): Ensure eth_getTransactionCount returns correct nonce for 'pending' tag #16407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2025
+4 −3
Merged

fix(RPC): Ensure eth_getTransactionCount returns correct nonce for 'pending' tag #16407

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ecc412b
Fix: Correctly derive next nonce for pending tag
keanji-x May 22, 2025
7f01899
fix doc
keanji-x May 22, 2025
4258301
fmt
keanji-x May 22, 2025
d1f4f58
fmt
keanji-x May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/rpc/rpc-eth-api/src/helpers/state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,9 +323,10 @@ pub trait LoadState:
.unwrap_or_default();

if block_id == Some(BlockId::pending()) {
// for pending tag we need to find the highest nonce in the pool
if let Some(highest_pool_tx) =
this.pool().get_highest_transaction_by_sender(address)
// for pending tag we need to find the highest nonce of txn in the pending state.
if let Some(highest_pool_tx) = this
.pool()
.get_highest_consecutive_transaction_by_sender(address, on_chain_account_nonce)
{
{
// and the corresponding txcount is nonce + 1 of the highest tx in the pool
Expand Down
Loading