Skip to content

perf: use already recovered signer #16640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

perf: use already recovered signer #16640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions crates/rpc/rpc-eth-types/src/gas_oracle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,12 @@
//! previous blocks.

use super::{EthApiError, EthResult, EthStateCache, RpcInvalidTransactionError};
use alloy_consensus::{
constants::GWEI_TO_WEI, transaction::SignerRecoverable, BlockHeader, Transaction,
};
use alloy_consensus::{constants::GWEI_TO_WEI, BlockHeader, Transaction};
use alloy_eips::BlockNumberOrTag;
use alloy_primitives::{B256, U256};
use alloy_rpc_types_eth::BlockId;
use derive_more::{Deref, DerefMut, From, Into};
use itertools::Itertools;
use reth_primitives_traits::BlockBody;
use reth_rpc_server_types::{
constants,
constants::gas_oracle::{
Expand Down Expand Up @@ -234,7 +231,7 @@ where
let parent_hash = block.parent_hash();

// sort the functions by ascending effective tip first
let sorted_transactions = block.body().transactions_iter().sorted_by_cached_key(|tx| {
let sorted_transactions = block.transactions_recovered().sorted_by_cached_key(|tx| {
if let Some(base_fee) = base_fee_per_gas {
(*tx).effective_tip_per_gas(base_fee)
} else {
Expand All @@ -259,10 +256,8 @@ where
}

// check if the sender was the coinbase, if so, ignore
if let Ok(sender) = tx.recover_signer() {
if sender == block.beneficiary() {
continue
}
if tx.signer() == block.beneficiary() {
continue
}

// a `None` effective_gas_tip represents a transaction where the max_fee_per_gas is
Expand Down
Loading