feat: Improve tx manager hash packing #19738
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKarl98
requested review from
Rjected,
klkvr,
mattsse and
shekhirin
as code owners
mattsse
reviewed
Nov 15, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
cool, all of this looks very good
need a bit more time to review this in detail, but we can move forward with this
Comment on lines
+413
to
+417
| fn try_request_via_peer_queue( | ||
| &mut self, | ||
| peers: &HashMap<PeerId, PeerMetadata<N>>, | ||
| search_durations: &mut TxFetcherSearchDurations, | ||
| ) -> bool { |
Collaborator
There was a problem hiding this comment.
could we add some additional docs to this?
CodSpeed Performance ReportMerging #19738 will degrade performances by 29.02%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Summary on solving the issue #19705 :
Introduced per-peer pending queues with event-driven scheduling: announcements, request failures, and completions , now immediately trigger try_schedule_pending_fetches, eliminating reliance on poll-time budgets.
Factored the request-packing logic into a reusable RequestBuilder that enforces hash/byte dual limits (mirroring geth’s scheduleFetches) and added boundary unit tests.
Removed the legacy search_breadth_budget_* and related constants; per-peer scheduling is enabled by default and exposed through the CLI/config.
Enhanced observability with new metrics (peer queue size/hash count) and Prometheus panels so the new scheduler’s health is visible at a glance.
Geth inspiration:
State-machine layout with per-peer queues.
Request construction governed by both hash count and estimated payload size.
Immediate, event-driven scheduling plus richer instrumentation.
cc @mattsse @Rjected @klkvr @shekhirin