fix: use correct dictionary in create_tx_compressor #19840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found and fixed a bug in
create_tx_compressor()- it was usingRECEIPT_DICTIONARYinstead ofTRANSACTION_DICTIONARY. This is a classic copy-paste error from when the code was added in #13250.The function is used in 3 places across the codebase to compress transactions, so using the wrong dictionary means worse compression. The thread-local
TRANSACTION_COMPRESSORalready uses the correct dictionary, but this standalone function didn't.Also cleaned up the docs while I was here - changed "Fn creates" to "Creates a" to match the rest of the codebase (881 other examples use this style), and replaced the wildcard import with explicit imports.